Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect App Mesh object state in status #11

Closed
nckturner opened this issue Mar 18, 2019 · 1 comment
Closed

Reflect App Mesh object state in status #11

nckturner opened this issue Mar 18, 2019 · 1 comment

Comments

@nckturner
Copy link
Contributor

In order to clean up objects in App Mesh when custom resources are deleted (#10), we need to reflect those objects state in the status field for custom resources. App Mesh resources currently have their own Status field, which can be ACTIVE, INACTIVE, or DELETED. My current thoughts are we can have one of:

  • a condition for each of these possible states (each condition value can be True, False, or Unknown),
  • or a top level appMeshStatus which just reflects the App Mesh status.

I am leaning towards using a condition for each state, because although its a bit of a strange translation, it reflects the direction that the Kubernetes API is moving (conditions instead of things like Pod phase). Its also easier to add conditions without breaking client assumptions if the App Mesh API changes in the future or we want to add other similar states.

@astrived
Copy link

This is addressed as part of 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants