Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getUrl message is misleading #1088

Open
davecramer opened this issue Aug 13, 2024 · 1 comment
Open

getUrl message is misleading #1088

davecramer opened this issue Aug 13, 2024 · 1 comment
Labels
question Further information is requested

Comments

@davecramer
Copy link
Contributor

davecramer commented Aug 13, 2024

This message ends up looking like ```
WARNING: Failed to connect to reader host: 'database-1-instance-1.XYZ.us-east-1.rds.amazonaws.com/'


we should probably call getHost() instead.
@aaron-congo
Copy link
Contributor

aaron-congo commented Sep 4, 2024

Hi @davecramer, can you clarify what is misleading about the message? If you compare the getUrl() and getHost() methods of the HostSpec class, using getHost() instead of getUrl() will only remove the slash at the end (also, if a port was specified, it will remove the port from the message).

@aaron-congo aaron-congo added the question Further information is requested label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants