Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if we need to have global STS endpoint #472

Open
jaydeokar opened this issue Sep 17, 2024 · 0 comments
Open

Investigate if we need to have global STS endpoint #472

jaydeokar opened this issue Sep 17, 2024 · 0 comments
Labels
need investigation Need some research to go forward

Comments

@jaydeokar
Copy link
Contributor

jaydeokar commented Sep 17, 2024

What would you like to be enhanced:
Investigate if we need to have a global fallback sts endpoint as per this comment

// Get the global sts end point
// TODO: we should revisit the global sts endpoint and check if we should remove global endpoint
// we are not using it since the concern on availability and performance
// https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_enable-regions.html

Also this piece of code where if regional STS !=global STS we still end up using the regional STS endpoint. It should be global STS if regional is not available.

if regionalSTSEndpoint.URL != globalSTSEndpoint.URL {
globalProvider := &stscreds.AssumeRoleProvider{
Client: e.createSTSClient(userStsSession, client, regionalSTSEndpoint, sourceAcct, sourceArn),

Why is the change needed and what use case will it solve:

@jaydeokar jaydeokar added enhancement New feature or request need investigation Need some research to go forward and removed enhancement New feature or request labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need investigation Need some research to go forward
Projects
None yet
Development

No branches or pull requests

1 participant