Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/lib: use tester v0.8.5 #875

Merged
merged 1 commit into from
Mar 20, 2020
Merged

scripts/lib: use tester v0.8.5 #875

merged 1 commit into from
Mar 20, 2020

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Mar 19, 2020

Worker nodes logs aren't used for now, so disable.

https://github.com/aws/aws-k8s-tester/blob/master/CHANGELOG-0.8.md

@jaypipes
Copy link
Contributor

@gyuho what do you mean by "worker nodes aren't used for now"? The MNG's worker nodes are indeed used to house Pods that are spun up in the integration tests...

@gyuho
Copy link
Contributor Author

gyuho commented Mar 19, 2020

@jaypipes Meant to say worker nodes "logs" :)

@SaranBalaji90
Copy link
Contributor

@gyuho worker nodes logs are useful while investigating failures. What's the harm in uploading these logs? Do we pay for these extra spaces somewhere?

@gyuho
Copy link
Contributor Author

gyuho commented Mar 19, 2020

@SaranBalaji90 Currently, the tester tool only downloads to the local machine. Uploading config file and kubeconfig to S3 bucket is supported but upload all logging files aren't "yet". I can implement this feature in the next release.

@gyuho
Copy link
Contributor Author

gyuho commented Mar 19, 2020

Updated upstream to upload gzipped file

{"level":"info","ts":"2020-03-19T11:50:50.525-0700","caller":"mng/logs.go:464","msg":"wrote log files","instance-id":"i-07bd14ea952b037ea","files":133,"total-downloaded-files":133}
{"level":"info","ts":"2020-03-19T11:50:50.526-0700","caller":"mng/logs.go:471","msg":"wrote all log files","log-dir":"/tmp/leegyuho-test-prod-logs-mngs","total-downloaded-files":133}
{"level":"info","ts":"2020-03-19T11:50:50.531-0700","caller":"mng/logs.go:68","msg":"gzipping logs dir","logs-dir":"/tmp/leegyuho-test-prod-logs-mngs","file-path":"/tmp/leegyuho-test-prod-mng-logs.tar.gz"}
{"level":"info","ts":"2020-03-19T11:50:50.577-0700","caller":"mng/logs.go:74","msg":"gzipped logs dir","logs-dir":"/tmp/leegyuho-test-prod-logs-mngs","file-path":"/tmp/leegyuho-test-prod-mng-logs.tar.gz"}
{"level":"info","ts":"2020-03-19T11:50:51.403-0700","caller":"mng/logs.go:99","msg":"uploaded the gzipped file","bucket":"aws-k8s-tester-eks-s3-bucket","remote-path":"leegyuho-test-prod/leegyuho-test-prod-mng-logs.tar.gz"}

Will release a new one.

@gyuho gyuho changed the title scripts/lib: use tester v0.7.8, do not fetch worker node logs scripts/lib: use tester v0.8.0 Mar 19, 2020
@gyuho
Copy link
Contributor Author

gyuho commented Mar 19, 2020

@jaypipes @SaranBalaji90 Released a new one
https://github.com/aws/aws-k8s-tester/blob/master/CHANGELOG-0.8.md.

Now uploads gzipped log files to S3 bucket.

@gyuho gyuho changed the title scripts/lib: use tester v0.8.0 scripts/lib: use tester v0.8.1 Mar 19, 2020
@mogren
Copy link
Contributor

mogren commented Mar 19, 2020

@jaypipes @SaranBalaji90 Released a new one
https://github.com/aws/aws-k8s-tester/blob/master/CHANGELOG-0.8.md.

Now uploads gzipped log files to S3 bucket.

Nice! Running the tests now

@gyuho gyuho changed the title scripts/lib: use tester v0.8.1 scripts/lib: use tester v0.8.2 Mar 19, 2020
@gyuho gyuho changed the title scripts/lib: use tester v0.8.2 scripts/lib: use tester v0.8.3 Mar 19, 2020
@SaranBalaji90
Copy link
Contributor

@gyuho what I meant to ask is, do we still upload kubelet logs? that's super useful for investigation.

@gyuho
Copy link
Contributor Author

gyuho commented Mar 19, 2020

@SaranBalaji90 Yes. e.g. i-00a1505dc938f9296-kubelet.service.out.log is the kubelet logs from the instance i-00a1505dc938f9296

@gyuho gyuho changed the title scripts/lib: use tester v0.8.3 scripts/lib: use tester v0.8.4 Mar 20, 2020
@gyuho gyuho changed the title scripts/lib: use tester v0.8.4 scripts/lib: use tester v0.8.5 Mar 20, 2020
Uploads worker node logs to S3 bucket (gzipped)

Signed-off-by: Gyuho Lee <[email protected]>
Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mogren mogren merged commit 28f2785 into aws:master Mar 20, 2020
@gyuho gyuho deleted the tester branch March 20, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants