Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENIs fails to be Tagged by CNI #610

Closed
vipulsabhaya opened this issue Sep 6, 2019 · 0 comments
Closed

ENIs fails to be Tagged by CNI #610

vipulsabhaya opened this issue Sep 6, 2019 · 0 comments
Labels
bug priority/P0 Highest priority. Someone needs to actively work on this.
Milestone

Comments

@vipulsabhaya
Copy link
Contributor

The VPC CNI plugin allocates ENIs on-demand for Pods. CNI also tags all ENIs that it created with the tag 'node.k8s.amazonaws.com/instance_id'.

There is a race condition in the code, such that we attempt to CreateTag prior to the ENI being fully ready, which causes the CreateTag call to fail. We don't attempt to retry the tag creation.

The result is some ENIs have a Tag, and some don't.

We need to ensure all ENIs tags are reliable, so they can be used for reconciliation or cleanup.

@mogren mogren added bug priority/P0 Highest priority. Someone needs to actively work on this. labels Sep 6, 2019
@mogren mogren added this to the v1.6 milestone Sep 6, 2019
@mogren mogren closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority/P0 Highest priority. Someone needs to actively work on this.
Projects
None yet
Development

No branches or pull requests

2 participants