Fix error handling in node label update path

[vikasmb]

What happened:

In

amazon-vpc-cni-k8s/pkg/ipamd/ipamd.go

Line 1883 in 8d05975

log.Errorf("Failed to update node %s with label %q: %q, error: %v", c.myNodeName, key, value, err)

if error occurs in node label update, it needs to return error to the caller.

Instead, it logs the error and continues on to indicate that it updated the node with the label in

amazon-vpc-cni-k8s/pkg/ipamd/ipamd.go

Line 1885 in 8d05975

log.Debugf("Updated node %s with label %q: %q", c.myNodeName, key, value)

Attach logs

What you expected to happen:
If error occurs in node label update, it needs to return error to the caller.
How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version):
• CNI Version 1.10.2
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):

[M00nF1sh]

we should consider use TwoWayStrategicMergePatch instead of update. (which saves request payload & we can disable resource version check safely for this use case)

https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/76bd7e3fc59a3dffa28397db2991edfd1a5889c7/pkg/targetgroupbinding/resource_manager.go#L503

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.