Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change e2e tests to IMDSv2 only nodes #1728

Closed
chlunde opened this issue Nov 5, 2021 · 2 comments
Closed

Change e2e tests to IMDSv2 only nodes #1728

chlunde opened this issue Nov 5, 2021 · 2 comments
Assignees
@cgchinmay
Labels
testing

Comments

@chlunde
Copy link

chlunde commented Nov 5, 2021

What would you like to be added:
Change e2e tests to IMDSv2 only nodes

Why is this needed:
Because IMDSv2 is recommended and we need to test for that (which also will work on IMDSv1+v2 setups)

https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html
https://github.com/kubernetes/kops/pull/10324/files

Please add label "testing" as requested in the PR template, I can't do that.

Related: #1727
@cgchinmay cgchinmay assigned cgchinmay and unassigned Shreya027 Feb 17, 2022
@cgchinmay cgchinmay mentioned this issue Feb 18, 2022
Merged
@jayanthvn
Copy link
Contributor

#1873 merged to master.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgchinmay cgchinmay

Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chlunde @jayanthvn @cgchinmay @Shreya027