Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add node label to enable trunk creation when there is room for a new ENI, even if ENABLE_POD_ENI=true #1202

Closed
mogren opened this issue Sep 9, 2020 · 3 comments
Labels
bug enhancement priority/P1 Must be staffed and worked currently or soon. Is a candidate for next release

Comments

@mogren
Copy link
Contributor

mogren commented Sep 9, 2020

What would you like to be added:

When ENABLE_POD_ENI=true, we always add the vpc.amazonaws.com/has-trunk-attached=false signaling that for a 1.17 eks.3 EKS cluster or later, an additional ENI should get attached. If the maximum number of ENIs are already attached, (or if MAX_ENI=1), we should not set the label.

Why is this needed:

We should only set the label to attach an additional ENI when we have room for it to avoid potential issues.

@SaranBalaji90
Copy link
Contributor

Can we make the ipamd to add the label only when trunk ENI can be created? Then we can mitigate this problem

@mogren
Copy link
Contributor Author

mogren commented Sep 9, 2020

Sounds good. I can rename this issue.

@mogren mogren changed the title Update documentation to clarify how ENABLE_POD_ENI works with MAX_ENI Only add node label to enable trunk creation when there is room for a new ENI, even if ENABLE_POD_ENI=true Sep 9, 2020
@mogren mogren added priority/P1 Must be staffed and worked currently or soon. Is a candidate for next release and removed documentation labels Sep 9, 2020
@mogren
Copy link
Contributor Author

mogren commented Sep 23, 2020

Fix merged.

@mogren mogren closed this as completed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement priority/P1 Must be staffed and worked currently or soon. Is a candidate for next release
Projects
None yet
Development

No branches or pull requests

2 participants