Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add multi-user-project byod scenario and updated ReadMe for potential errors + workarounds #4790

Open
wants to merge 3 commits into
base: default
Choose a base branch
from

Conversation

svia3
Copy link
Contributor

@svia3 svia3 commented Nov 28, 2024

…ntial errors + workarounds

Issue #, if available:

  • Address the scenario where user whats to in addition to flow A - link project B, created environment B, subset of usersB to create a punch out link for flow B.
  • update README to add some helpful common errors and workarounds

Description of changes:

  • loop on critical linking functionality
  • remove fed role as arg param in exchange for input during script execution as to enable FedRoleA to be used on first pass, and FedRoleB to be used on second.

Testing done:

  • manual using two different roles in HULK testing account
  • Project A, Environment A, UserA that has ExecutionRole A and FederationRole A -> generate punch out link and verify assets appear in studio UI. Same for flow B.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have verified that my PR does not contain any new notebook/s which demonstrate a SageMaker functionality already showcased by another existing notebook in the repository
  • I have read the CONTRIBUTING doc and adhered to the guidelines regarding folder placement, notebook naming convention and example notebook best practices
  • I have updated the necessary documentation, including the README of the appropriate folder as well as the index.rst file
  • I have tested my notebook(s) and ensured it runs end-to-end
  • I have linted my notebook(s) and code using python3 -m black -l 100 {path}/{notebook-name}.ipynb

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@svia3 svia3 changed the title fix: add multi-user-project byod scenario and updated ReadMe for pote… fix: add multi-user-project byod scenario and updated ReadMe for potential errors + workarounds Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants