Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncating after compression #183

Closed
matthewfala opened this issue Nov 10, 2021 · 1 comment
Closed

Truncating after compression #183

matthewfala opened this issue Nov 10, 2021 · 1 comment

Comments

@matthewfala
Copy link
Contributor

I noticed that truncation is occurring after compression in kinesis streams.

I'm not sure that the plugin can truncate compressed data and expect it to still be in a valid compressed format.

here is the plugin's current assumption

truncate(compress(data)) == compress(truncate(data))

Does that hold true for gzip and zlib?

data = data[:maximumRecordSize-partitionKeyLen-len(truncatedSuffix)]

If not then the current truncation system may need to be replaced.

@PettitWesley PettitWesley added the bug Something isn't working label Nov 11, 2021
@zhonghui12 zhonghui12 added pending release and removed bug Something isn't working labels Jan 29, 2022
@zhonghui12
Copy link
Contributor

This fix has been included in latest release: https://github.com/aws/aws-for-fluent-bit/releases/tag/v2.22.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants