Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart for Deployments #4

Open
jinglejengel opened this issue Sep 4, 2019 · 8 comments
Open

Helm Chart for Deployments #4

jinglejengel opened this issue Sep 4, 2019 · 8 comments

Comments

@jinglejengel
Copy link

What would you like to be added: Helm chart for standardised deployment

Why is this needed: Helm is widely used in the k8s community for deploying resources across clusters. This would allow for teams to bake existing workflows in things like terraform, ansible, etc. more easily than the current Makefile, as well as allow more customisation where needed for teams that may have different access control needs or configuration needs wrt some of the resources created for this.


Looking at the Makefile, I don't think this is an insurmountable task at all :D Looks like the only iffy part might be the cert generation?

If I can find the spare cycles, I might just pick this one up myself.

@micahhausler
Copy link
Member

Hey thanks, I think a Helm chart would be great, and I'd be happy to be a co-maintainer on one in https://github.com/helm/charts/. I think we'd want to keep it in the helm/charts repository so we can get all the CI/release goodness that is automatically setup there

@jinglejengel
Copy link
Author

@micahhausler agreed on putting it in the helm repo, figured I'd file the FR here for tracking for the EKS side of the house. (:

@max-rocket-internet
Copy link

I made a PR: helm/charts#17099

We don't have a docker image yet due to #5 but the merge process for the charts repo is very slow so I figured I'd open the PR now.

Questions:

  1. The name of the chart. I shortened it and removed eks. My reasoning is that amazon is too general and long and that eks is not 100% accurate as it can and will be used in non-eks clusters. Happy to rename it if you want though.
  2. Is the installation instruction correct? And the NOTES.txt? I wrote this after reading the Makefile and README.

@micahhausler
Copy link
Member

Thanks for making the Chart PR! I'll review it later today

  1. I think the name is great

  2. I'll comment on the chart later today

I think in order to be an OWNER in a chart repo you have to be a github.com/helm org member, which unfortunately isn't automated yet. I'm happy to join as a Member and will comment on the Chart PR, but @max-rocket-internet you should probably poke some org admin who can invite the listed OWNERS. I'll have @jqmichael and @nckturner comment on the chart PR with their owner/org request status

@max-rocket-internet
Copy link

I think the name is great

🎉

you should probably poke some org admin who can invite the listed OWNERS. I'll have @jqmichael and @nckturner comment on the chart PR with their owner/org request status

I'll try but I don't see much movement in that area these days. It seems it's always the same people (and bottleneck) for reviewing chart PRs.

@hlascelles
Copy link

NB, for anyone arriving here: @max-rocket-internet has closed the initial PR opened in the main helm repo in favour of one in the aws repo: aws/eks-charts#28 (also opened by him). Upvote it there (bearing in mind it is stalled on an a docker image build).

@danopia
Copy link

danopia commented Oct 22, 2020

For continuation, there's a new PR in the aws repo now that a docker image has been published: aws/eks-charts#286

@jkroepke
Copy link

jkroepke commented Apr 1, 2022

In meantime, I provide a helm chart which optionally support the cert-manager or static generated tls certificates.

https://github.com/jkroepke/helm-charts/tree/main/charts/amazon-eks-pod-identity-webhook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants