[AD-771] fix issue of JDBC not returning tables #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tableau passes catalog, schema, table name, and table type as null pointers to SQLTables. PowerBI passes catalog, schema, and table name as null pointers to SQLTables. PowerBI passes column name as null pointers to SQLColumns. Therefore, if null is passed in ODBC as table pattern, "%" needs to be passed as table pattern to JDBC. Same thing with null being passed to ODBC as column name pattern.
|
https://github.com/Bit-Quill/amazon-documentdb-odbc-driver-mirror/pull/34 |
* move comments for SQLTables and SQLColumns from odbc.h to odbc.cpp. * refactor code to use `get_value_or` when retrieving values for table and column name
birschick-bq
approved these changes
Jun 8, 2022
affonsov
pushed a commit
that referenced
this pull request
Nov 16, 2022
### Summary <!--- General summary / title --> Make JDBC return tables/columns to ODBC ### Description <!--- Details of what you changed --> * Tableau passes catalog, schema, table name, and table type as null pointers to SQLTables. PowerBI passes catalog, schema, and table name as null pointers to SQLTables. PowerBI passes column name as null pointers to SQLColumns. Therefore, if null is passed in ODBC as table pattern, "%" needs to be passed as table pattern to JDBC. Same thing with null being passed to ODBC as column name pattern. ### Related Issue <!--- Link to issue where this is tracked --> https://bitquill.atlassian.net/browse/AD-771 * [AD-771] fix issue of JDBC not returning tables * Tableau passes catalog, schema, table name, and table type as null pointers to SQLTables. PowerBI passes catalog, schema, and table name as null pointers to SQLTables. PowerBI passes column name as null pointers to SQLColumns. Therefore, if null is passed in ODBC as table pattern, "%" needs to be passed as table pattern to JDBC. Same thing with null being passed to ODBC as column name pattern. * [AD-771] add checks for passing null table/column names * [AD-771] resolve code review comments * move comments for SQLTables and SQLColumns from odbc.h to odbc.cpp. * refactor code to use `get_value_or` when retrieving values for table and column name
affonsov
pushed a commit
that referenced
this pull request
Nov 17, 2022
### Summary <!--- General summary / title --> Make JDBC return tables/columns to ODBC ### Description <!--- Details of what you changed --> * Tableau passes catalog, schema, table name, and table type as null pointers to SQLTables. PowerBI passes catalog, schema, and table name as null pointers to SQLTables. PowerBI passes column name as null pointers to SQLColumns. Therefore, if null is passed in ODBC as table pattern, "%" needs to be passed as table pattern to JDBC. Same thing with null being passed to ODBC as column name pattern. ### Related Issue <!--- Link to issue where this is tracked --> https://bitquill.atlassian.net/browse/AD-771 * [AD-771] fix issue of JDBC not returning tables * Tableau passes catalog, schema, table name, and table type as null pointers to SQLTables. PowerBI passes catalog, schema, and table name as null pointers to SQLTables. PowerBI passes column name as null pointers to SQLColumns. Therefore, if null is passed in ODBC as table pattern, "%" needs to be passed as table pattern to JDBC. Same thing with null being passed to ODBC as column name pattern. * [AD-771] add checks for passing null table/column names * [AD-771] resolve code review comments * move comments for SQLTables and SQLColumns from odbc.h to odbc.cpp. * refactor code to use `get_value_or` when retrieving values for table and column name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make JDBC return tables/columns to ODBC
Description
PowerBI passes catalog, schema, and table name as null pointers to SQLTables.
PowerBI passes column name as null pointers to SQLColumns.
Therefore, if null is passed in ODBC as table pattern, "%" needs to be passed as table pattern to JDBC.
Same thing with null being passed to ODBC as column name pattern.
Related Issue
https://bitquill.atlassian.net/browse/AD-771
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022