Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AD-644] Tableau show metadata #55

Merged
merged 25 commits into from
Mar 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f58451b
[AD-604] Query execution adaption
Mar 21, 2022
155f6de
[AD-591] update word doc for SetResultsetMeta
alinaliBQ Mar 22, 2022
33f1457
Merge branch 'birschick-bq/ad-604/query-execution' into alinaliBQ/AD-…
alinaliBQ Mar 22, 2022
6130215
[AD-591] refactor changes
alinaliBQ Mar 22, 2022
5c26603
[AD-591] implement read jdbc metadata function
alinaliBQ Mar 22, 2022
e81d48c
[AD-591] populate resultMeta for DataQuery class
alinaliBQ Mar 22, 2022
7a43952
[AD-591] fix mac build error
alinaliBQ Mar 22, 2022
72afe09
[AD-591] change TestSQLNumResultColsStub test
alinaliBQ Mar 22, 2022
185ac2a
[AD-591] update test name to avoid duplicate
alinaliBQ Mar 22, 2022
defc313
[AD-591] remove unneeded comments
alinaliBQ Mar 22, 2022
a4f16a6
[AD-591] add copy of original ignite code for reference
alinaliBQ Mar 22, 2022
e5d429f
[AD-591] make PowerBI show metadata
alinaliBQ Mar 22, 2022
e41a99e
[AD-591] add output for IgnitError in MakeRequestResultsetMeta
alinaliBQ Mar 22, 2022
9b99c72
[AD-591] remove comments and old ignite code
alinaliBQ Mar 22, 2022
ab93354
[AD-591] modify MakeRequestExecute to avoid duplicate code
alinaliBQ Mar 22, 2022
a5be3a8
[AD-644] add log messages and notes
alinaliBQ Mar 23, 2022
ca3a645
[AD-644] set SQL_IDENTIFIER_QUOTE_CHAR to double quotes
alinaliBQ Mar 24, 2022
fb497c7
[AD-644] fix rowArraySize bug
alinaliBQ Mar 24, 2022
8dd4122
Revert "[AD-644] add log messages and notes"
alinaliBQ Mar 24, 2022
ea520e1
[AD-644] logs
alinaliBQ Mar 25, 2022
1bb0d44
Revert "[AD-644] logs"
alinaliBQ Mar 25, 2022
6637633
Merge branch 'develop' into alinaliBQ/AD-644/show_tableau_meta
alinaliBQ Mar 25, 2022
f6079f6
[AD-644] nit remove empty new line
alinaliBQ Mar 25, 2022
8f83fdf
[AD-644] undo remove new line
alinaliBQ Mar 25, 2022
8b55418
[AD-644] remove empty space
alinaliBQ Mar 25, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/odbc/src/config/connection_info.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ ConnectionInfo::ConnectionInfo(const Configuration& config)
// quoted (delimited) identifier in SQL statements. Identifiers passed as
// arguments to ODBC functions do not have to be quoted. If the data source
// does not support quoted identifiers, a blank is returned.
strParams[SQL_IDENTIFIER_QUOTE_CHAR] = "";
strParams[SQL_IDENTIFIER_QUOTE_CHAR] = "\"";
#endif // SQL_IDENTIFIER_QUOTE_CHAR

#ifdef SQL_CATALOG_NAME_SEPARATOR
Expand Down
2 changes: 1 addition & 1 deletion src/odbc/src/statement.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ SqlResult::Type Statement::InternalGetAttribute(int attr, void* buf, SQLINTEGER,
case SQL_ATTR_ROW_ARRAY_SIZE: {
SQLINTEGER* val = reinterpret_cast< SQLINTEGER* >(buf);

*val = static_cast< SQLINTEGER >(1);
*val = static_cast< SQLINTEGER >(rowArraySize);

if (valueLen)
*valueLen = SQL_IS_INTEGER;
Expand Down