-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AD-504] Apache Ignite ODBC Seed replacement #4
Conversation
* Initial commit with support for Windows build without test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
* Add support for compiling tests.
* Correct GitHub workflow.
* Correct GitHub workflow.
* Correct GitHub workflow.
* Disable building of test code.
* Update .gitignore
* Update for MacOS build script.
* Re-enable cppcheck.
* Disable cppcheck.
* Add install of OpenSSL.
* Set OPENSSL_ROOT_DIR for macOS.
* Set OPENSSL_ROOT_DIR for macOS.
* Set OPENSSL_ROOT_DIR for macOS.
* Remove Window-specific method from MacOS/Linux code
Build for MacOS is failling with:
|
This error looks like possibly what @affonsoBQ came across. @affonsoBQ could you document how you solved this? |
Installing unixodbc helped with this issue, let's add it to the README
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Code coverage can be added later.
* [AD-915] Embed JRE into install. Simplify versioning of JDBC driver. * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Attempting to debug Windows 32-bit JDBC installer * [AD-915] Attempting fix to Windows 32-bit JDBC installer * [AD-915] Correct indentation formatting. * [AD-915] Code review improvements. * [AD-915] Temporary enable creating artifacts to get 32-bit installer. * [AD-915] Remove unnecessary "verbose" on jpackage command. * [AD-915] Fixed Platform setting in JDBC installer main.wxs.in * [AD-915] Replace JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Increase tracing info for JDK installation with script on Windows. * [AD-915] Change parameter to JDK installer script. * [AD-915] Create JDKs directory, if not exists. * [AD-915] Fix syntax - Create JDKs directory, if not exists. * [AD-915] Fix location - Create JDKs directory, if not exists. * [AD-915] Fix setting of JAVA_HOME environment variable in GitHub workflow. * [AD-915] Get full path of JDKs folder. * [AD-915] Fix Resolve-Path call. * [AD-915] Add path to $JAVA_HOME/bin * [AD-915] Refactor code to use 'jlink' and create a runtime image instead of application for 'jpackage'. * [AD-915] Attempt to build Windows 32-bit installer using 'jpackage'. * [AD-915] Attempt #2 to build Windows 32-bit installer using 'jpackage'. * [AD-915] More clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #2 to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #3 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #4 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Remove commented unused code. * [AD-915] Fix path to JVM.dll in JDBC installer template. * [AD-915] Set artifacts to be made on push to the develop branch. * [AD-915] Improve naming and version numbers for installer * [AD-915] Remove unused icon file. * [AD-915] Rename a installer resource for better clarity. * [AD-915] Add tracing for JLINK_VERSION. * [AD-915] Fix issue with JLINK_VERSION having more than 3 version components. * [AD-915] Code review changes. * [AD-915] Revert code to create artifacts - so now only on push to develop branch.
Re-sync develop to main branch
### Summary [AD-504] Apache Ignite ODBC Seed replacement ### Description * Initial commit with support for Windows and MacOS build **without test**. * Seeded from [Apache Ignite](https://github.com/apache/ignite) from the path [modules/platforms/cpp](https://github.com/apache/ignite/tree/master/modules/platforms/cpp). ### Related Issue [[AD-504] Apache Ignite ODBC Seed replacement](https://bitquill.atlassian.net/browse/AD-506) * [AD-504] Apache Ignite ODBC Seed replacement * Initial commit with support for Windows build without test. * [AD-504] Apache Ignite ODBC Seed replacement * Add support for compiling tests. * [AD-504] Apache Ignite ODBC Seed replacement * Correct GitHub workflow. * [AD-504] Apache Ignite ODBC Seed replacement * Correct GitHub workflow. * [AD-504] Apache Ignite ODBC Seed replacement * Correct GitHub workflow. * [AD-504] Apache Ignite ODBC Seed replacement * Disable building of test code. * [AD-504] Apache Ignite ODBC Seed replacement * Update .gitignore * adding mac build and workflow * temporarily disabling cppcheck * [AD-504] Apache Ignite ODBC Seed replacement * Update for MacOS build script. * [AD-504] Apache Ignite ODBC Seed replacement * Re-enable cppcheck. * [AD-504] Apache Ignite ODBC Seed replacement * Disable cppcheck. * [AD-504] Apache Ignite ODBC Seed replacement * Add install of OpenSSL. * [AD-504] Apache Ignite ODBC Seed replacement * Set OPENSSL_ROOT_DIR for macOS. * [AD-504] Apache Ignite ODBC Seed replacement * Set OPENSSL_ROOT_DIR for macOS. * [AD-504] Apache Ignite ODBC Seed replacement * Set OPENSSL_ROOT_DIR for macOS. * [AD-504] Apache Ignite ODBC Seed replacement * Remove Window-specific method from MacOS/Linux code * [AD-504] Improve MacOS build. * [AD-504] Improve MacOS build docs. Co-authored-by: affonsov <[email protected]>
* [AD-915] Embed JRE into install. Simplify versioning of JDBC driver. * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Attempting to debug Windows 32-bit JDBC installer * [AD-915] Attempting fix to Windows 32-bit JDBC installer * [AD-915] Correct indentation formatting. * [AD-915] Code review improvements. * [AD-915] Temporary enable creating artifacts to get 32-bit installer. * [AD-915] Remove unnecessary "verbose" on jpackage command. * [AD-915] Fixed Platform setting in JDBC installer main.wxs.in * [AD-915] Replace JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Increase tracing info for JDK installation with script on Windows. * [AD-915] Change parameter to JDK installer script. * [AD-915] Create JDKs directory, if not exists. * [AD-915] Fix syntax - Create JDKs directory, if not exists. * [AD-915] Fix location - Create JDKs directory, if not exists. * [AD-915] Fix setting of JAVA_HOME environment variable in GitHub workflow. * [AD-915] Get full path of JDKs folder. * [AD-915] Fix Resolve-Path call. * [AD-915] Add path to $JAVA_HOME/bin * [AD-915] Refactor code to use 'jlink' and create a runtime image instead of application for 'jpackage'. * [AD-915] Attempt to build Windows 32-bit installer using 'jpackage'. * [AD-915] Attempt #2 to build Windows 32-bit installer using 'jpackage'. * [AD-915] More clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #2 to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #3 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #4 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Remove commented unused code. * [AD-915] Fix path to JVM.dll in JDBC installer template. * [AD-915] Set artifacts to be made on push to the develop branch. * [AD-915] Improve naming and version numbers for installer * [AD-915] Remove unused icon file. * [AD-915] Rename a installer resource for better clarity. * [AD-915] Add tracing for JLINK_VERSION. * [AD-915] Fix issue with JLINK_VERSION having more than 3 version components. * [AD-915] Code review changes. * [AD-915] Revert code to create artifacts - so now only on push to develop branch.
Re-sync develop to main branch
### Summary [AD-504] Apache Ignite ODBC Seed replacement ### Description * Initial commit with support for Windows and MacOS build **without test**. * Seeded from [Apache Ignite](https://github.com/apache/ignite) from the path [modules/platforms/cpp](https://github.com/apache/ignite/tree/master/modules/platforms/cpp). ### Related Issue [[AD-504] Apache Ignite ODBC Seed replacement](https://bitquill.atlassian.net/browse/AD-506) * [AD-504] Apache Ignite ODBC Seed replacement * Initial commit with support for Windows build without test. * [AD-504] Apache Ignite ODBC Seed replacement * Add support for compiling tests. * [AD-504] Apache Ignite ODBC Seed replacement * Correct GitHub workflow. * [AD-504] Apache Ignite ODBC Seed replacement * Correct GitHub workflow. * [AD-504] Apache Ignite ODBC Seed replacement * Correct GitHub workflow. * [AD-504] Apache Ignite ODBC Seed replacement * Disable building of test code. * [AD-504] Apache Ignite ODBC Seed replacement * Update .gitignore * adding mac build and workflow * temporarily disabling cppcheck * [AD-504] Apache Ignite ODBC Seed replacement * Update for MacOS build script. * [AD-504] Apache Ignite ODBC Seed replacement * Re-enable cppcheck. * [AD-504] Apache Ignite ODBC Seed replacement * Disable cppcheck. * [AD-504] Apache Ignite ODBC Seed replacement * Add install of OpenSSL. * [AD-504] Apache Ignite ODBC Seed replacement * Set OPENSSL_ROOT_DIR for macOS. * [AD-504] Apache Ignite ODBC Seed replacement * Set OPENSSL_ROOT_DIR for macOS. * [AD-504] Apache Ignite ODBC Seed replacement * Set OPENSSL_ROOT_DIR for macOS. * [AD-504] Apache Ignite ODBC Seed replacement * Remove Window-specific method from MacOS/Linux code * [AD-504] Improve MacOS build. * [AD-504] Improve MacOS build docs. Co-authored-by: affonsov <[email protected]>
* [AD-915] Embed JRE into install. Simplify versioning of JDBC driver. * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Attempting to debug Windows 32-bit JDBC installer * [AD-915] Attempting fix to Windows 32-bit JDBC installer * [AD-915] Correct indentation formatting. * [AD-915] Code review improvements. * [AD-915] Temporary enable creating artifacts to get 32-bit installer. * [AD-915] Remove unnecessary "verbose" on jpackage command. * [AD-915] Fixed Platform setting in JDBC installer main.wxs.in * [AD-915] Replace JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Increase tracing info for JDK installation with script on Windows. * [AD-915] Change parameter to JDK installer script. * [AD-915] Create JDKs directory, if not exists. * [AD-915] Fix syntax - Create JDKs directory, if not exists. * [AD-915] Fix location - Create JDKs directory, if not exists. * [AD-915] Fix setting of JAVA_HOME environment variable in GitHub workflow. * [AD-915] Get full path of JDKs folder. * [AD-915] Fix Resolve-Path call. * [AD-915] Add path to $JAVA_HOME/bin * [AD-915] Refactor code to use 'jlink' and create a runtime image instead of application for 'jpackage'. * [AD-915] Attempt to build Windows 32-bit installer using 'jpackage'. * [AD-915] Attempt #2 to build Windows 32-bit installer using 'jpackage'. * [AD-915] More clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #2 to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #3 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #4 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Remove commented unused code. * [AD-915] Fix path to JVM.dll in JDBC installer template. * [AD-915] Set artifacts to be made on push to the develop branch. * [AD-915] Improve naming and version numbers for installer * [AD-915] Remove unused icon file. * [AD-915] Rename a installer resource for better clarity. * [AD-915] Add tracing for JLINK_VERSION. * [AD-915] Fix issue with JLINK_VERSION having more than 3 version components. * [AD-915] Code review changes. * [AD-915] Revert code to create artifacts - so now only on push to develop branch.
At 598 GitHub action odbc
Re-sync develop to main branch
* [AD-1040] Resolve DirectQuery issues for scroll and filter. * [AD-1040] Fixed tests. * [AD-1040] Attempt to fix Mac build. * [AD-1040] Attempt to fix Mac build - #2. * [AD-1040] Attempt to fix Mac build - #3. * [AD-1040] Attempt to fix Mac build - #4. * [AD-1040] Attempt to fix Mac build - #5. * [AD-1040] Comment for fix of libiodbc brew package. * [AD-1040] Recover missing merge material * [AD-1040] Recover missing merge material - #2 * [AD-1040] Revert unintentional merge content. * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1040] Changes from code review comment. * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1069] Changes from code review comment. * Commit Code Coverage Badge * Commit Code Coverage Badge Co-authored-by: birschick-bq <[email protected]>
* [AD-1040] Initial improvement of Power BI connector settings. * Commit Code Coverage Badge * [AD-1040] Temporary work-around to generate the artifacts on pull request. * Commit Code Coverage Badge * [AD-1040] Updated connector configuration. SQL_MAX_CONCURRENT_ACTIVITIES = 1. * [AD-1040] Correct test. * Commit Code Coverage Badge * [AD-1040] Correct spelling and test to use DSN instead of individual properties. * Commit Code Coverage Badge * [AD-1040] Remove unused connection string settings. * [AD-1040] Attempt fix of commit Commit Coverage Badge on Mac. * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1040] Attempt fix of commit Commit Coverage Badge on Mac - #2. * [AD-1040] Attempt fix of commit Commit Coverage Badge on Windows. * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1040] Attempt fix of TruffleHog on Windows. * Commit Code Coverage Badge * [AD-1040] Attempt fix of TruffleHog on Windows - #2. * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1040] Attempt fix of TruffleHog on Windows - #3. * [AD-1040] Attempt fix of TruffleHog on Windows - #4. * [AD-1040] Attempt fix of TruffleHog on Windows - #5. * Commit Code Coverage Badge * Commit Code Coverage Badge * Commit Code Coverage Badge * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1040] Clean-up TruffleHog changes. * Commit Code Coverage Badge * [AD-1040] Documented TODO: items to investigate to improve the SQLGetInfo properties accuracy. * Commit Code Coverage Badge * [AD-1040] Improved support of DirectQuery. Can now handle numbers. But still no support for Timestamp. * [AD-1040] Fix unit tests. Improve readability of connector file. * Commit Code Coverage Badge * [AD-1040] Attempt fix of pinning mongo-cxx-driver to version specific version. * [AD-1040] Attempt fix of pinning mongo-cxx-driver to version specific version - #2. * [AD-1040] Attempt fix of pinning mongo-cxx-driver to version specific version - #3. * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1040] Attempt fix of pinning mongo-cxx-driver to version specific version - #4. * Commit Code Coverage Badge * Adding Documentation and renaming functions * fix dsn parameter * Commit Code Coverage Badge * [AD-1040] Attempt to expand capabilities to solve problem of folding error. * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1040] Some small changes and clean-up of interim comments. * Commit Code Coverage Badge * fixing scrolling and filtering * Commit Code Coverage Badge * [AD-1040] Resolve DirectQuery issues for scroll and filter. * [AD-1040] Fixed tests. * Commit Code Coverage Badge * [AD-1040] Attempt to fix Mac build. * [AD-1040] Attempt to fix Mac build - #2. * Commit Code Coverage Badge * [AD-1040] Attempt to fix Mac build - #3. * Commit Code Coverage Badge * [AD-1040] Attempt to fix Mac build - #4. * [AD-1040] Attempt to fix Mac build - #5. * Commit Code Coverage Badge * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1040] Comment for fix of libiodbc brew package. * [AD-1040] Resolve DirectQuery issues for scroll and filter. * [AD-1040] Fixed tests. * [AD-1040] Attempt to fix Mac build. * [AD-1040] Attempt to fix Mac build - #2. * [AD-1040] Attempt to fix Mac build - #3. * [AD-1040] Attempt to fix Mac build - #4. * [AD-1040] Attempt to fix Mac build - #5. * [AD-1040] Comment for fix of libiodbc brew package. * Commit Code Coverage Badge * [AD-1040] Recover missing merge material * [AD-1040] Recover missing merge material - #2 * [AD-1040] Revert unintentional merge content. * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1040] Changes from code review comment. * Commit Code Coverage Badge * Commit Code Coverage Badge * [AD-1040] Changes from code review comments. * Commit Code Coverage Badge Co-authored-by: birschick-bq <[email protected]> Co-authored-by: Affonso Vieira <[email protected]> Co-authored-by: affonsoBQ <[email protected]>
Summary
[AD-504] Apache Ignite ODBC Seed replacement
Description
Related Issue
[AD-504] Apache Ignite ODBC Seed replacement
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@andiem-bq
@birschick-bq
@garya-bitquill