Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AD-492] Working JNI GitHub workflow #2

Merged
merged 16 commits into from
Dec 20, 2021

Conversation

birschick-bq
Copy link
Contributor

@birschick-bq birschick-bq commented Dec 7, 2021

Summary

[AD-492] Working JNI GitHub workflow

Description

  • Change GitHub workflows to enable JNI build.
  • Ensure path to JVM library is available at runtime.
  • Remove support for Linux 32-bit.

Related Issue

https:/bitquill.atlassian.net/browse/AD-492

Additional Reviewers

@affonsoBQ
@alexey-temnikov
@andiem-bq
@birschick-bq
@garya-bitquill

Bruce Irschick added 11 commits December 7, 2021 13:01
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
…vered.

https:/bitquill.atlassian.net/browse/AD-492
@birschick-bq birschick-bq marked this pull request as ready for review December 8, 2021 18:26
Bruce Irschick added 2 commits December 8, 2021 10:56
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
Copy link
Contributor

@affonsov affonsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Bruce Irschick added 2 commits December 15, 2021 14:55
https:/bitquill.atlassian.net/browse/AD-492
https:/bitquill.atlassian.net/browse/AD-492
Copy link
Contributor

@garya-bitquill garya-bitquill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@birschick-bq birschick-bq merged commit e8d46e4 into develop Dec 20, 2021
@birschick-bq birschick-bq deleted the birschick-bq/ad-492/jni_workflow branch December 20, 2021 18:30
andiemontoyeah pushed a commit that referenced this pull request Feb 4, 2022
birschick-bq pushed a commit that referenced this pull request Oct 4, 2022
birschick-bq pushed a commit that referenced this pull request Oct 6, 2022
* [AD-915] Embed JRE into install. Simplify versioning of JDBC driver.

* [AD-915] Fixed setting the JDBC_DRIVER_VERSION

* [AD-915] Fixed setting the JDBC_DRIVER_VERSION

* [AD-915] Fixed setting the JDBC_DRIVER_VERSION

* [AD-915] Attempting to debug Windows 32-bit JDBC installer

* [AD-915] Attempting fix to Windows 32-bit JDBC installer

* [AD-915] Correct indentation formatting.

* [AD-915] Code review improvements.

* [AD-915] Temporary enable creating artifacts to get 32-bit installer.

* [AD-915] Remove unnecessary "verbose" on jpackage command.

* [AD-915] Fixed Platform setting in JDBC installer main.wxs.in

* [AD-915] Replace JDK installation with script on Windows.

* [AD-915] Attempt fix of JDK installation with script on Windows.

* [AD-915] Attempt fix of JDK installation with script on Windows.

* [AD-915] Increase tracing info for JDK installation with script on Windows.

* [AD-915] Change parameter to JDK installer script.

* [AD-915] Create JDKs directory, if not exists.

* [AD-915] Fix syntax - Create JDKs directory, if not exists.

* [AD-915] Fix location - Create JDKs directory, if not exists.

* [AD-915] Fix setting of JAVA_HOME environment variable in GitHub workflow.

* [AD-915] Get full path of JDKs folder.

* [AD-915] Fix Resolve-Path call.

* [AD-915] Add path to $JAVA_HOME/bin

* [AD-915] Refactor code to use 'jlink' and create a runtime image instead of application for 'jpackage'.

* [AD-915] Attempt to build Windows 32-bit installer using 'jpackage'.

* [AD-915] Attempt #2 to build Windows 32-bit installer using 'jpackage'.

* [AD-915] More clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt to fix clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt #2 to fix clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt #3 to clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt #4 to clean-up and make release artifacts smaller/cleaner.

* [AD-915] Remove commented unused code.

* [AD-915] Fix path to JVM.dll in JDBC installer template.

* [AD-915] Set artifacts to be made on push to the develop branch.

* [AD-915] Improve naming and version numbers for installer

* [AD-915] Remove unused icon file.

* [AD-915] Rename a installer resource for better clarity.

* [AD-915] Add tracing for JLINK_VERSION.

* [AD-915] Fix issue with JLINK_VERSION having more than 3 version components.

* [AD-915] Code review changes.

* [AD-915] Revert code to create artifacts - so now only on push to develop branch.
affonsov pushed a commit that referenced this pull request Nov 16, 2022
AT-609 Fix: Revert change to timestream-write
affonsov pushed a commit that referenced this pull request Nov 16, 2022
* Replaced aws-profile, iam, aad and okta with default authentication.

* Delete aad_credentials_provider(h,cpp) source files.

* Delete okta_credentials_provider(h,cpp) source files.

* Delete saml_credentials_provider(h,cpp) source files.

* Remove commented out code from test_conn.cpp.

* Remove commented out code from dlg_specific.h.

* Remove commented out code from dlg_wingui.c.

* Remove commented out code from drvconn.c.

* Remove commented out code from odbc.h.

* Remove commented out code from odbc_communication.cpp

* Remove commented out code from odbc_communication.h

* Remove commented out code from resource.h.

* Remove commented out code from setup.c.

* Change 'AUTHMODE_CNT' for 4 to 1.

* Remove extra line with 4 trailing white spaces.

* Set DEFAULT_AUTHTYPE to equal AUTHTYPE_DEFAULT.

* Remove 'IDC_TOKEN_STATIC' and 'IDC_TOKEN'.

* Bug fix: declare pwdp variable inside hide_password function.

* Implement SetDlgStuff and GetDlgStuff for default authentication method.

* In dconn_FDriverConnectProc function, for default authentication set focus to user item.

* In SetDlgStuff function wrap pwd in SAFE_NAME macro.

* Remove remaining commented out code.
affonsov pushed a commit that referenced this pull request Nov 16, 2022
### Summary

[AD-492] Working JNI GitHub workflow

### Description

* Change GitHub workflows to enable JNI build.
* Ensure path to JVM library is available at runtime.
* Remove support for Linux 32-bit.

### Related Issue

https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Working JNI GitHub workflow
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Use different action.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Disable Linux 32-bit build.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Disable Windows 32-bit build.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Debugging test_main.cpp.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Debugging test_main.cpp.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Update path for Java.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Update path for Java.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Update path for Java.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Re-enable Windows 32-bit.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Solidify placement and ensure all platforms/workflows are covered.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Remove debugging test_main.cpp.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Remove build steps for 32-bit Linux.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Add license headers.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Review improvements some use of smart pointers.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Resolve warning (for MacOS/Linux).
https:/bitquill.atlassian.net/browse/AD-492
affonsov pushed a commit that referenced this pull request Nov 16, 2022
* [AD-915] Embed JRE into install. Simplify versioning of JDBC driver.

* [AD-915] Fixed setting the JDBC_DRIVER_VERSION

* [AD-915] Fixed setting the JDBC_DRIVER_VERSION

* [AD-915] Fixed setting the JDBC_DRIVER_VERSION

* [AD-915] Attempting to debug Windows 32-bit JDBC installer

* [AD-915] Attempting fix to Windows 32-bit JDBC installer

* [AD-915] Correct indentation formatting.

* [AD-915] Code review improvements.

* [AD-915] Temporary enable creating artifacts to get 32-bit installer.

* [AD-915] Remove unnecessary "verbose" on jpackage command.

* [AD-915] Fixed Platform setting in JDBC installer main.wxs.in

* [AD-915] Replace JDK installation with script on Windows.

* [AD-915] Attempt fix of JDK installation with script on Windows.

* [AD-915] Attempt fix of JDK installation with script on Windows.

* [AD-915] Increase tracing info for JDK installation with script on Windows.

* [AD-915] Change parameter to JDK installer script.

* [AD-915] Create JDKs directory, if not exists.

* [AD-915] Fix syntax - Create JDKs directory, if not exists.

* [AD-915] Fix location - Create JDKs directory, if not exists.

* [AD-915] Fix setting of JAVA_HOME environment variable in GitHub workflow.

* [AD-915] Get full path of JDKs folder.

* [AD-915] Fix Resolve-Path call.

* [AD-915] Add path to $JAVA_HOME/bin

* [AD-915] Refactor code to use 'jlink' and create a runtime image instead of application for 'jpackage'.

* [AD-915] Attempt to build Windows 32-bit installer using 'jpackage'.

* [AD-915] Attempt #2 to build Windows 32-bit installer using 'jpackage'.

* [AD-915] More clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt to fix clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt #2 to fix clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt #3 to clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt #4 to clean-up and make release artifacts smaller/cleaner.

* [AD-915] Remove commented unused code.

* [AD-915] Fix path to JVM.dll in JDBC installer template.

* [AD-915] Set artifacts to be made on push to the develop branch.

* [AD-915] Improve naming and version numbers for installer

* [AD-915] Remove unused icon file.

* [AD-915] Rename a installer resource for better clarity.

* [AD-915] Add tracing for JLINK_VERSION.

* [AD-915] Fix issue with JLINK_VERSION having more than 3 version components.

* [AD-915] Code review changes.

* [AD-915] Revert code to create artifacts - so now only on push to develop branch.
affonsov pushed a commit that referenced this pull request Nov 17, 2022
AT-609 Fix: Revert change to timestream-write
affonsov pushed a commit that referenced this pull request Nov 17, 2022
* Replaced aws-profile, iam, aad and okta with default authentication.

* Delete aad_credentials_provider(h,cpp) source files.

* Delete okta_credentials_provider(h,cpp) source files.

* Delete saml_credentials_provider(h,cpp) source files.

* Remove commented out code from test_conn.cpp.

* Remove commented out code from dlg_specific.h.

* Remove commented out code from dlg_wingui.c.

* Remove commented out code from drvconn.c.

* Remove commented out code from odbc.h.

* Remove commented out code from odbc_communication.cpp

* Remove commented out code from odbc_communication.h

* Remove commented out code from resource.h.

* Remove commented out code from setup.c.

* Change 'AUTHMODE_CNT' for 4 to 1.

* Remove extra line with 4 trailing white spaces.

* Set DEFAULT_AUTHTYPE to equal AUTHTYPE_DEFAULT.

* Remove 'IDC_TOKEN_STATIC' and 'IDC_TOKEN'.

* Bug fix: declare pwdp variable inside hide_password function.

* Implement SetDlgStuff and GetDlgStuff for default authentication method.

* In dconn_FDriverConnectProc function, for default authentication set focus to user item.

* In SetDlgStuff function wrap pwd in SAFE_NAME macro.

* Remove remaining commented out code.
affonsov pushed a commit that referenced this pull request Nov 17, 2022
### Summary

[AD-492] Working JNI GitHub workflow

### Description

* Change GitHub workflows to enable JNI build.
* Ensure path to JVM library is available at runtime.
* Remove support for Linux 32-bit.

### Related Issue

https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Working JNI GitHub workflow
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Use different action.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Disable Linux 32-bit build.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Disable Windows 32-bit build.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Debugging test_main.cpp.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Debugging test_main.cpp.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Update path for Java.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Update path for Java.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Update path for Java.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Re-enable Windows 32-bit.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Solidify placement and ensure all platforms/workflows are covered.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Remove debugging test_main.cpp.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Remove build steps for 32-bit Linux.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Add license headers.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Review improvements some use of smart pointers.
https:/bitquill.atlassian.net/browse/AD-492

* [AD-492] Resolve warning (for MacOS/Linux).
https:/bitquill.atlassian.net/browse/AD-492
affonsov pushed a commit that referenced this pull request Nov 17, 2022
* [AD-915] Embed JRE into install. Simplify versioning of JDBC driver.

* [AD-915] Fixed setting the JDBC_DRIVER_VERSION

* [AD-915] Fixed setting the JDBC_DRIVER_VERSION

* [AD-915] Fixed setting the JDBC_DRIVER_VERSION

* [AD-915] Attempting to debug Windows 32-bit JDBC installer

* [AD-915] Attempting fix to Windows 32-bit JDBC installer

* [AD-915] Correct indentation formatting.

* [AD-915] Code review improvements.

* [AD-915] Temporary enable creating artifacts to get 32-bit installer.

* [AD-915] Remove unnecessary "verbose" on jpackage command.

* [AD-915] Fixed Platform setting in JDBC installer main.wxs.in

* [AD-915] Replace JDK installation with script on Windows.

* [AD-915] Attempt fix of JDK installation with script on Windows.

* [AD-915] Attempt fix of JDK installation with script on Windows.

* [AD-915] Increase tracing info for JDK installation with script on Windows.

* [AD-915] Change parameter to JDK installer script.

* [AD-915] Create JDKs directory, if not exists.

* [AD-915] Fix syntax - Create JDKs directory, if not exists.

* [AD-915] Fix location - Create JDKs directory, if not exists.

* [AD-915] Fix setting of JAVA_HOME environment variable in GitHub workflow.

* [AD-915] Get full path of JDKs folder.

* [AD-915] Fix Resolve-Path call.

* [AD-915] Add path to $JAVA_HOME/bin

* [AD-915] Refactor code to use 'jlink' and create a runtime image instead of application for 'jpackage'.

* [AD-915] Attempt to build Windows 32-bit installer using 'jpackage'.

* [AD-915] Attempt #2 to build Windows 32-bit installer using 'jpackage'.

* [AD-915] More clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt to fix clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt #2 to fix clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt #3 to clean-up and make release artifacts smaller/cleaner.

* [AD-915] Attempt #4 to clean-up and make release artifacts smaller/cleaner.

* [AD-915] Remove commented unused code.

* [AD-915] Fix path to JVM.dll in JDBC installer template.

* [AD-915] Set artifacts to be made on push to the develop branch.

* [AD-915] Improve naming and version numbers for installer

* [AD-915] Remove unused icon file.

* [AD-915] Rename a installer resource for better clarity.

* [AD-915] Add tracing for JLINK_VERSION.

* [AD-915] Fix issue with JLINK_VERSION having more than 3 version components.

* [AD-915] Code review changes.

* [AD-915] Revert code to create artifacts - so now only on push to develop branch.
birschick-bq pushed a commit that referenced this pull request Jan 12, 2023
alexey-temnikov pushed a commit that referenced this pull request Jan 14, 2023
AT-609 Fix: Revert change to timestream-write
alexey-temnikov pushed a commit that referenced this pull request Jan 14, 2023
* Replaced aws-profile, iam, aad and okta with default authentication.

* Delete aad_credentials_provider(h,cpp) source files.

* Delete okta_credentials_provider(h,cpp) source files.

* Delete saml_credentials_provider(h,cpp) source files.

* Remove commented out code from test_conn.cpp.

* Remove commented out code from dlg_specific.h.

* Remove commented out code from dlg_wingui.c.

* Remove commented out code from drvconn.c.

* Remove commented out code from odbc.h.

* Remove commented out code from odbc_communication.cpp

* Remove commented out code from odbc_communication.h

* Remove commented out code from resource.h.

* Remove commented out code from setup.c.

* Change 'AUTHMODE_CNT' for 4 to 1.

* Remove extra line with 4 trailing white spaces.

* Set DEFAULT_AUTHTYPE to equal AUTHTYPE_DEFAULT.

* Remove 'IDC_TOKEN_STATIC' and 'IDC_TOKEN'.

* Bug fix: declare pwdp variable inside hide_password function.

* Implement SetDlgStuff and GetDlgStuff for default authentication method.

* In dconn_FDriverConnectProc function, for default authentication set focus to user item.

* In SetDlgStuff function wrap pwd in SAFE_NAME macro.

* Remove remaining commented out code.
birschick-bq pushed a commit that referenced this pull request Jan 20, 2023
birschick-bq pushed a commit that referenced this pull request Jan 20, 2023
birschick-bq pushed a commit that referenced this pull request Jan 20, 2023
birschick-bq added a commit that referenced this pull request Jan 20, 2023
* [AD-1040] Resolve DirectQuery issues for scroll and filter.

* [AD-1040] Fixed tests.

* [AD-1040] Attempt to fix Mac build.

* [AD-1040] Attempt to fix Mac build - #2.

* [AD-1040] Attempt to fix Mac build - #3.

* [AD-1040] Attempt to fix Mac build - #4.

* [AD-1040] Attempt to fix Mac build - #5.

* [AD-1040] Comment for fix of libiodbc brew package.

* [AD-1040] Recover missing merge material

* [AD-1040] Recover missing merge material - #2

* [AD-1040] Revert unintentional merge content.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1040] Changes from code review comment.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1069] Changes from code review comment.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

Co-authored-by: birschick-bq <[email protected]>
birschick-bq added a commit that referenced this pull request Jan 21, 2023
* [AD-1040] Initial improvement of Power BI connector settings.

* Commit Code Coverage Badge

* [AD-1040] Temporary work-around to generate the artifacts on pull request.

* Commit Code Coverage Badge

* [AD-1040] Updated connector configuration. SQL_MAX_CONCURRENT_ACTIVITIES = 1.

* [AD-1040] Correct test.

* Commit Code Coverage Badge

* [AD-1040] Correct spelling and test to use DSN instead of individual properties.

* Commit Code Coverage Badge

* [AD-1040] Remove unused connection string settings.

* [AD-1040] Attempt fix of commit Commit Coverage Badge on Mac.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1040] Attempt fix of commit Commit Coverage Badge on Mac - #2.

* [AD-1040] Attempt fix of commit Commit Coverage Badge on Windows.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1040] Attempt fix of TruffleHog on Windows.

* Commit Code Coverage Badge

* [AD-1040] Attempt fix of TruffleHog on Windows - #2.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1040] Attempt fix of TruffleHog on Windows - #3.

* [AD-1040] Attempt fix of TruffleHog on Windows - #4.

* [AD-1040] Attempt fix of TruffleHog on Windows - #5.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1040] Clean-up TruffleHog changes.

* Commit Code Coverage Badge

* [AD-1040] Documented TODO: items to investigate to improve the SQLGetInfo properties accuracy.

* Commit Code Coverage Badge

* [AD-1040] Improved support of DirectQuery. Can now handle numbers. But still no support for Timestamp.

* [AD-1040] Fix unit tests. Improve readability of connector file.

* Commit Code Coverage Badge

* [AD-1040] Attempt fix of pinning mongo-cxx-driver to version specific version.

* [AD-1040] Attempt fix of pinning mongo-cxx-driver to version specific version - #2.

* [AD-1040] Attempt fix of pinning mongo-cxx-driver to version specific version - #3.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1040] Attempt fix of pinning mongo-cxx-driver to version specific version - #4.

* Commit Code Coverage Badge

* Adding Documentation and renaming functions

* fix dsn parameter

* Commit Code Coverage Badge

* [AD-1040] Attempt to expand capabilities to solve problem of folding error.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1040] Some small changes and clean-up of interim comments.

* Commit Code Coverage Badge

* fixing scrolling and filtering

* Commit Code Coverage Badge

* [AD-1040] Resolve DirectQuery issues for scroll and filter.

* [AD-1040] Fixed tests.

* Commit Code Coverage Badge

* [AD-1040] Attempt to fix Mac build.

* [AD-1040] Attempt to fix Mac build - #2.

* Commit Code Coverage Badge

* [AD-1040] Attempt to fix Mac build - #3.

* Commit Code Coverage Badge

* [AD-1040] Attempt to fix Mac build - #4.

* [AD-1040] Attempt to fix Mac build - #5.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1040] Comment for fix of libiodbc brew package.

* [AD-1040] Resolve DirectQuery issues for scroll and filter.

* [AD-1040] Fixed tests.

* [AD-1040] Attempt to fix Mac build.

* [AD-1040] Attempt to fix Mac build - #2.

* [AD-1040] Attempt to fix Mac build - #3.

* [AD-1040] Attempt to fix Mac build - #4.

* [AD-1040] Attempt to fix Mac build - #5.

* [AD-1040] Comment for fix of libiodbc brew package.

* Commit Code Coverage Badge

* [AD-1040] Recover missing merge material

* [AD-1040] Recover missing merge material - #2

* [AD-1040] Revert unintentional merge content.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1040] Changes from code review comment.

* Commit Code Coverage Badge

* Commit Code Coverage Badge

* [AD-1040] Changes from code review comments.

* Commit Code Coverage Badge

Co-authored-by: birschick-bq <[email protected]>
Co-authored-by: Affonso Vieira <[email protected]>
Co-authored-by: affonsoBQ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants