-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AD-915] Auto Installer - JVM included #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
reviewed
Sep 29, 2022
birschick-bq
commented
Oct 6, 2022
affonsov
approved these changes
Oct 6, 2022
alinaliBQ
reviewed
Oct 6, 2022
alinaliBQ
suggested changes
Oct 6, 2022
Ubuntu 20.04 Debug Build Unit Test Results Check
|
MacOS Big Sur 11 Debug Build Code Coverage Result
|
alinaliBQ
approved these changes
Oct 6, 2022
affonsov
pushed a commit
that referenced
this pull request
Nov 16, 2022
* [AD-915] Embed JRE into install. Simplify versioning of JDBC driver. * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Attempting to debug Windows 32-bit JDBC installer * [AD-915] Attempting fix to Windows 32-bit JDBC installer * [AD-915] Correct indentation formatting. * [AD-915] Code review improvements. * [AD-915] Temporary enable creating artifacts to get 32-bit installer. * [AD-915] Remove unnecessary "verbose" on jpackage command. * [AD-915] Fixed Platform setting in JDBC installer main.wxs.in * [AD-915] Replace JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Increase tracing info for JDK installation with script on Windows. * [AD-915] Change parameter to JDK installer script. * [AD-915] Create JDKs directory, if not exists. * [AD-915] Fix syntax - Create JDKs directory, if not exists. * [AD-915] Fix location - Create JDKs directory, if not exists. * [AD-915] Fix setting of JAVA_HOME environment variable in GitHub workflow. * [AD-915] Get full path of JDKs folder. * [AD-915] Fix Resolve-Path call. * [AD-915] Add path to $JAVA_HOME/bin * [AD-915] Refactor code to use 'jlink' and create a runtime image instead of application for 'jpackage'. * [AD-915] Attempt to build Windows 32-bit installer using 'jpackage'. * [AD-915] Attempt #2 to build Windows 32-bit installer using 'jpackage'. * [AD-915] More clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #2 to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #3 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #4 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Remove commented unused code. * [AD-915] Fix path to JVM.dll in JDBC installer template. * [AD-915] Set artifacts to be made on push to the develop branch. * [AD-915] Improve naming and version numbers for installer * [AD-915] Remove unused icon file. * [AD-915] Rename a installer resource for better clarity. * [AD-915] Add tracing for JLINK_VERSION. * [AD-915] Fix issue with JLINK_VERSION having more than 3 version components. * [AD-915] Code review changes. * [AD-915] Revert code to create artifacts - so now only on push to develop branch.
affonsov
pushed a commit
that referenced
this pull request
Nov 17, 2022
* [AD-915] Embed JRE into install. Simplify versioning of JDBC driver. * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Attempting to debug Windows 32-bit JDBC installer * [AD-915] Attempting fix to Windows 32-bit JDBC installer * [AD-915] Correct indentation formatting. * [AD-915] Code review improvements. * [AD-915] Temporary enable creating artifacts to get 32-bit installer. * [AD-915] Remove unnecessary "verbose" on jpackage command. * [AD-915] Fixed Platform setting in JDBC installer main.wxs.in * [AD-915] Replace JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Increase tracing info for JDK installation with script on Windows. * [AD-915] Change parameter to JDK installer script. * [AD-915] Create JDKs directory, if not exists. * [AD-915] Fix syntax - Create JDKs directory, if not exists. * [AD-915] Fix location - Create JDKs directory, if not exists. * [AD-915] Fix setting of JAVA_HOME environment variable in GitHub workflow. * [AD-915] Get full path of JDKs folder. * [AD-915] Fix Resolve-Path call. * [AD-915] Add path to $JAVA_HOME/bin * [AD-915] Refactor code to use 'jlink' and create a runtime image instead of application for 'jpackage'. * [AD-915] Attempt to build Windows 32-bit installer using 'jpackage'. * [AD-915] Attempt #2 to build Windows 32-bit installer using 'jpackage'. * [AD-915] More clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #2 to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #3 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #4 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Remove commented unused code. * [AD-915] Fix path to JVM.dll in JDBC installer template. * [AD-915] Set artifacts to be made on push to the develop branch. * [AD-915] Improve naming and version numbers for installer * [AD-915] Remove unused icon file. * [AD-915] Rename a installer resource for better clarity. * [AD-915] Add tracing for JLINK_VERSION. * [AD-915] Fix issue with JLINK_VERSION having more than 3 version components. * [AD-915] Code review changes. * [AD-915] Revert code to create artifacts - so now only on push to develop branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[AD-915] Embed JRE into install. Simplify versioning of JDBC driver.
Description
Related Issue
https://bitquill.atlassian.net/browse/AD-915
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022