Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make POSTLogger start() and stop() public methods #2475

Open
everscending opened this issue Oct 19, 2022 · 1 comment
Open

Make POSTLogger start() and stop() public methods #2475

everscending opened this issue Oct 19, 2022 · 1 comment
Labels
feature-request New feature or request

Comments

@everscending
Copy link

Community Note

  • Please vote for this issue by adding a 👍 reaction to the issue. This will help the community and maintainers from the Amazon Chime SDK team to prioritize this request.
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request.
  • Please go through the existing issues to see if your request has already been recommended.
  • Please do not use this template for bugs or support. Each individual repository has a PR template, documentation and resources for troubleshooting.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Tell us about your request

What do you want us to build?

Which Amazon Chime SDK or feature area is this request for?

This is a feature request for POSTLogger in
amazon-chime-sdk-js

Tell us about the problem you are trying to solve and why is it hard?

The more details you provide us, the better we will be able to help you.

The feature request is to change the start and stop methods in the POSTLogger class from private to public.

The reason is because of how the POSTLogger is created and passed into the UI library's LoggerProvider component.
The only way currently to get the logger to stop publishing events is to destroy it. In our use case we need the logger to start publishing logs again once the next meeting starts in the app.

How are you currently solving a problem?

2 options for making this work are:

  1. Once a component downstream from MeetingManager becomes aware that a new meeting has started, it calls a state dispatcher function(passed down through context) which causes a new POSTLogger to be created in the component that renders LoggerProvider. This is a poor pattern to use and makes the code unnecessarily complicated.
  2. Copy POSTLogger into our repo and change start/stop methods from private to public. Using this customized logger, we only need to create it once and easily start and stop publishing of logs when appropriate according to our needs. Obviously customizing Chime code is not preferable and should be avoided if there is no other choice.

Making these 2 methods public would solve our problem. At the very least, change them to protected so that a subclass can make them public. But really.. if there is not a super compelling reason not to, please just make them public.

Additional context

Anything else we should know?

@everscending everscending added the feature-request New feature or request label Oct 19, 2022
@michhyun1
Copy link
Contributor

Thank you for this feature request - we'll backlog this item and we'll post any updates here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants