Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Feature flag to turn on or off GeoRegistration #81

Open
robahall opened this issue Jul 11, 2024 · 1 comment
Open

Feature Request: Feature flag to turn on or off GeoRegistration #81

robahall opened this issue Jul 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@robahall
Copy link

robahall commented Jul 11, 2024

Feature Request: Geo-Registration Feature Flag

Summary:
Our team has developed an in-house geo-registration container, and we would like the ability to deactivate the GDAL-based or OSML based geo-registration in osml-model-runner. To achieve this, we propose adding a feature flag that allows users to enable or disable geo-registration as needed.

Details:

  • Feature Name: Geo-Registration Feature Flag
  • Description: Introduce a feature flag in osml-model-runner that provides the ability to enable or disable the built-in GDAL-based geo-registration functionality or OSML enabled.
  • Use Case: This feature is beneficial for teams that have their own custom geo-registration solutions and prefer not to use the GDAL-based geo-registration provided by osml-model-runner.
  • Implementation:
    • Add a configuration option (e.g., geo_registration_enabled) to the osml-model-runner settings.
    • When the feature flag is set to false, the osml-model-runner should skip the GDAL-based geo-registration process.
    • Ensure that this configuration option can be easily set through environment variables or a configuration file.
    • Provide documentation on how to enable or disable the geo-registration feature.

Benefits:

  • Allows for greater flexibility and customization for users with their own geo-registration solutions.
  • Reduces potential conflicts and redundancies when using custom geo-registration containers.

Example Configuration:

# osml-model-runner configuration file
geo_registration_enabled: false

Or, set through an environment variable:

export GEO_REGISTRATION_ENABLED=false

This revised version provides a clear summary, detailed description, and example configurations, making it easier for developers to understand the request and implement the feature.

@RanbirAulakh RanbirAulakh added the enhancement New feature or request label Sep 25, 2024
@RanbirAulakh
Copy link
Collaborator

Thank you for submitting this issue! We have added this in our backlog item and will get this prioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants