Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python api-cors-lambda out of date #381

Closed
alex9311 opened this issue Jan 4, 2021 · 1 comment · Fixed by #382
Closed

python api-cors-lambda out of date #381

alex9311 opened this issue Jan 4, 2021 · 1 comment · Fixed by #382
Assignees
@NGL321
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@alex9311
Copy link
Contributor

alex9311 commented Jan 4, 2021

🐛 Bug Report

What is the problem?

The python api-cors-lambda is out of date. aws/aws-cdk#4211 makes it much more straightforward to enable CORS on a REST API endpoint. The example code should be updated to reflect that.
@alex9311 alex9311 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 4, 2021
@alex9311 alex9311 mentioned this issue Jan 4, 2021
Merged
@NGL321 NGL321 self-assigned this Feb 1, 2021
@NGL321 NGL321 added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels May 17, 2021
@mergify mergify bot closed this as completed in #382 Jun 29, 2021
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NGL321 NGL321

Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update python api-cors-lambda alex9311/aws-cdk-examples
2 participants
@alex9311 @NGL321