Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): add example for AWS SAM #674
docs(examples): add example for AWS SAM #674
Changes from 6 commits
01324a8
9c3d999
ed0abd2
fd6acbc
644a76a
58a3ca4
ef8239a
cf2f9c6
8ce19c7
cb28daf
5266452
007c990
f6bc21c
caf39e2
b6953dc
d5969b8
a35bb80
7a355cf
5fd51c6
17831a3
3b68bdb
de14ec6
48425c0
6b55f2d
310c39f
ae2dddf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check indentation in this code block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation seems correct to me as in template.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's correct if you look at it relative to the larger template, but since this is a decontextualised code snippet it's a bit odd that the first line starts with 6 spaces.
Either way it's really a minor / nitpicky comment, you can leave it if you think it makes sense.