Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add support for nodejs16.x runtime #830

Closed
saragerion opened this issue May 9, 2022 · 6 comments · Fixed by #877
Closed

Feature request: add support for nodejs16.x runtime #830

saragerion opened this issue May 9, 2022 · 6 comments · Fixed by #877
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation

Comments

@saragerion
Copy link
Contributor

Description of the feature request

Problem statement

Support for nodejs16.x currently missing.

Summary of the feature

The runtime nodejs16.x will be GA this week, see this related issue.

As part of this issue, support for the Node.js v16 runtime should be added where relevant.

Code examples

N/A

Benefits for you and the wider AWS community

N/A

Describe alternatives you've considered

N/A

Additional context

N/A

Related issues, RFCs

aws/aws-lambda-base-images#14

@saragerion saragerion added the triage This item has not been triaged by a maintainer, please wait label May 9, 2022
@saragerion saragerion added this to the production-ready-release milestone May 9, 2022
@saragerion saragerion added documentation Improvements or additions to documentation enhancement automation This item relates to automation labels May 9, 2022
@dreamorosi
Copy link
Contributor

From a first round of research, here are some places that needs updating:

@dreamorosi
Copy link
Contributor

At the moment we are blocked by CDK releasing support for the new runtime (we use CDK in the integration tests).
The PR that adds support has been already merged yesterday aws/aws-cdk#20261 so hopefully it'll be released soon.

@willfarrell
Copy link

For those that run across this that use terraform: hashicorp/terraform-provider-aws#24714

@saragerion saragerion added the on-hold This item is on-hold and will be revisited in the future label May 10, 2022
@saragerion
Copy link
Contributor Author

On hold (hopefully for a relatively short time) until the CDK release containing this update: aws/aws-cdk#20261

@dreamorosi dreamorosi self-assigned this May 10, 2022
@dreamorosi
Copy link
Contributor

Both CDK and SAM added support for the new runtime, will link a PR to the issue shortly.

@dreamorosi dreamorosi linked a pull request May 13, 2022 that will close this issue
10 tasks
@saragerion saragerion removed the on-hold This item is on-hold and will be revisited in the future label May 16, 2022
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Oct 19, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
@dreamorosi dreamorosi changed the title Feature (all): add support for nodejs16.x runtime Feature request: add support for nodejs16.x runtime Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants