Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: fix typedoc-plugin-zod usage #2923

Closed
1 of 2 tasks
dreamorosi opened this issue Aug 13, 2024 · 3 comments · Fixed by #2949
Closed
1 of 2 tasks

Maintenance: fix typedoc-plugin-zod usage #2923

dreamorosi opened this issue Aug 13, 2024 · 3 comments · Fixed by #2949
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility

Comments

@dreamorosi
Copy link
Contributor

Summary

Currently we are using a Typedoc plugin called typedoc-plugin-zod which is expected to prettify the Zod schemas in our TypeDoc API docs.

This is working well enough, however when building the docs the plugin is causing thousands of warnings:

image

I was able to confirm that the plugin is the source of the warnings because commenting it out in the main typedoc.json config makes all the warnings immediately disappear.

We should investigate if this is: 1/ a bug with the plugin, 2/ a misconfiguration on our part, or 3/ a misuse of our typedoc annotations that causes the warnings.

Why is this needed?

So that we don't have thousands of warnings when generating the API docs.

Which area does this relate to?

Parser

Solution

In case of 2/ or 3/, we should fix it, in case of 1/ ideally we should open an issue on the plugin's repo to get it fixed. If none of the above is a viable option, we should look at alternatives or removing the plugin entirely.

The good thing is that the plugin is from the same author as Typedoc itself, so unless it's an issue with Zod itself I'm confident there will be a solution.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation parser This item relates to the Parser Utility labels Aug 13, 2024
@am29d
Copy link
Contributor

am29d commented Aug 13, 2024

I was also super annoyed by the spam in the logs, hard to see other warnings and errors. I will investigate.

@dreamorosi
Copy link
Contributor Author

Typedoc released a new version of their package as well as the Zod plugin. The new version was merged in #2949 and I was able to confirm that the warning logs are gone.

Thank you @am29d for opening the issue upstream and getting this fixed!

Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Aug 19, 2024
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility
Projects
2 participants