Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: fix typo in doc publishing workflow #1348

Closed
1 of 2 tasks
dreamorosi opened this issue Feb 28, 2023 · 1 comment · Fixed by #1349
Closed
1 of 2 tasks

Maintenance: fix typo in doc publishing workflow #1348

dreamorosi opened this issue Feb 28, 2023 · 1 comment · Fixed by #1349
Assignees
@dreamorosi
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

In a recent PR (#1124) we have made some changes to the way docs are published and mistakenly introduced a bug in the workflow that wasn't spotted during the review. This caused the workflow to fail during its first run after another unrelated PR was merged.

Based on the error message it appears that one of the GitHub global variables names has a typo: input vs inputs - with the latter being the correct one.

Why is this needed?

To allow the workflow to run properly.

Which area does this relate to?

Automation

Solution

See linked PR.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) completed This item is complete and has been merged/shipped labels Feb 28, 2023
@dreamorosi dreamorosi self-assigned this Feb 28, 2023
@dreamorosi dreamorosi mentioned this issue Feb 28, 2023
Merged
13 tasks
@dreamorosi dreamorosi linked a pull request Feb 28, 2023 that will close this issue
chore(ci): fix typo in doc publishing workflow #1349
Merged
13 tasks
@github-project-automation github-project-automation bot moved this from Shipped to Coming soon in AWS Lambda Powertools for TypeScript Feb 28, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Feb 28, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Feb 28, 2023
@dreamorosi dreamorosi removed the pending-release This item has been merged and will be released soon label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): fix typo in doc publishing workflow aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi