Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: bump CDK CLI version in publish_layer.yaml workflow #1231

Closed
1 of 2 tasks
dreamorosi opened this issue Jan 13, 2023 · 1 comment · Fixed by #1232
Closed
1 of 2 tasks

Maintenance: bump CDK CLI version in publish_layer.yaml workflow #1231

dreamorosi opened this issue Jan 13, 2023 · 1 comment · Fixed by #1232
Assignees
@dreamorosi
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Milestone
Lambda layer

Comments

@dreamorosi
Copy link
Contributor

Summary

The publish_layer.yaml workflow currently has a hardcoded version on the CDK CLI. Given that in #1228 we have recently bumped the version of the actual CDK stack, the fact that this is hardcoded makes it fail as they are not aligned.

Why is this needed?

Because if the two versions are not aligned the workflow might fail, like it happened here, preventing the layers to be published.

Which area does this relate to?

Automation

Solution

Temporarily, as a short term fix that allows us to publish layers, manually bump the version in the workflow to align it with the one used in the layer-publisher folder.

Later, remove the hardcoded version number from the workflow and manage the dependency in the layer-publisher workflow. This work is tracked in #1226.

Acknowledgment
@dreamorosi dreamorosi added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Jan 13, 2023
@dreamorosi dreamorosi added this to the Lambda layer milestone Jan 13, 2023
@dreamorosi dreamorosi self-assigned this Jan 13, 2023
@dreamorosi dreamorosi mentioned this issue Jan 13, 2023
Merged
13 tasks
@dreamorosi dreamorosi linked a pull request Jan 13, 2023 that will close this issue
chore(layers): bump hardcoded cdk version in publish_layer.yaml #1232
Merged
13 tasks
@dreamorosi dreamorosi moved this from Pending review to Shipped in AWS Lambda Powertools for TypeScript Jan 13, 2023
@dreamorosi dreamorosi added automation This item relates to automation completed This item is complete and has been merged/shipped and removed triage This item has not been triaged by a maintainer, please wait labels Jan 13, 2023
@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Jan 13, 2023
@dreamorosi dreamorosi removed the pending-release This item has been merged and will be released soon label Jan 13, 2023
@github-project-automation github-project-automation bot moved this from Shipped to Coming soon in AWS Lambda Powertools for TypeScript Jan 13, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Milestone
Lambda layer
1 participant
@dreamorosi