Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: integrate into CI/CD package measurement #1099

Closed
ijemmy opened this issue Sep 29, 2022 · 3 comments
Closed

Maintenance: integrate into CI/CD package measurement #1099

ijemmy opened this issue Sep 29, 2022 · 3 comments
Assignees
Labels
automation This item relates to automation idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) rejected This is something we will not be working on. At least, not in the measurable future

Comments

@ijemmy
Copy link
Contributor

ijemmy commented Sep 29, 2022

Description of the feature request

Problem statement
Before merging new code into main we are running a workflow that measures the impact of the changes on the final package size. The new utility should be part of this workflow.

Summary of the feature
This issue tracks the work needed to integrate the new utility as part of the workflow mentioned above. The output report that is generated should then include the idempotency util.

Code examples
N/A

Benefits for you and the wider AWS community
This will help the maintainers to make data driven decisions when it comes to package size.

Describe alternatives you've considered
N/A

Additional context
N/A

Related issues, RFCs

#447

@ijemmy ijemmy added triage This item has not been triaged by a maintainer, please wait idempotency This item relates to the Idempotency Utility on-hold This item is on-hold and will be revisited in the future labels Sep 29, 2022
@ijemmy
Copy link
Contributor Author

ijemmy commented Sep 29, 2022

Put this on-hold. Waiting for the implementation to be completed first.

@saragerion saragerion added this to the Idempotency milestone Sep 29, 2022
@dreamorosi dreamorosi moved this from On hold to Backlog in AWS Lambda Powertools for TypeScript Nov 13, 2022
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) automation This item relates to automation and removed triage This item has not been triaged by a maintainer, please wait labels Nov 13, 2022
@dreamorosi dreamorosi changed the title Feature (idempotency): integrate into CI/CD package measurement Maintenance: integrate into CI/CD package measurement Nov 14, 2022
@dreamorosi dreamorosi moved this from Backlog to Closed in AWS Lambda Powertools for TypeScript Jun 12, 2023
@dreamorosi dreamorosi added rejected This is something we will not be working on. At least, not in the measurable future and removed on-hold This item is on-hold and will be revisited in the future labels Jun 12, 2023
@dreamorosi dreamorosi self-assigned this Jun 12, 2023
@dreamorosi
Copy link
Contributor

Closing this issue as we are removing the workflow for the time being due to it relying on an unmaintained 3rd party action as well as being overly complex.

We'll reintroduce something similar once we work on benchmarks.

@dreamorosi dreamorosi closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
@github-project-automation github-project-automation bot moved this from Closed to Coming soon in AWS Lambda Powertools for TypeScript Jun 12, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) rejected This is something we will not be working on. At least, not in the measurable future
Projects
None yet
Development

No branches or pull requests

3 participants