From 8026e19384c26d669659075f1dbdbb702ff7d4a0 Mon Sep 17 00:00:00 2001 From: Andrea Amorosi Date: Fri, 20 Oct 2023 12:37:58 +0200 Subject: [PATCH] chore(parameters): fix code smells --- packages/parameters/src/appconfig/AppConfigProvider.ts | 4 ---- packages/parameters/src/dynamodb/DynamoDBProvider.ts | 4 ---- packages/parameters/tests/unit/BaseProvider.test.ts | 8 +++++++- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/packages/parameters/src/appconfig/AppConfigProvider.ts b/packages/parameters/src/appconfig/AppConfigProvider.ts index d092c57627..b5260ee229 100644 --- a/packages/parameters/src/appconfig/AppConfigProvider.ts +++ b/packages/parameters/src/appconfig/AppConfigProvider.ts @@ -10,10 +10,6 @@ import type { AppConfigGetOptions, AppConfigGetOutput, } from '../types/AppConfigProvider'; -/* import { - addUserAgentMiddleware, - isSdkClient, -} from '@aws-lambda-powertools/commons'; */ /** * ## Intro diff --git a/packages/parameters/src/dynamodb/DynamoDBProvider.ts b/packages/parameters/src/dynamodb/DynamoDBProvider.ts index cad56e7d6d..1263229cbe 100644 --- a/packages/parameters/src/dynamodb/DynamoDBProvider.ts +++ b/packages/parameters/src/dynamodb/DynamoDBProvider.ts @@ -18,10 +18,6 @@ import type { } from '@aws-sdk/client-dynamodb'; import type { PaginationConfiguration } from '@aws-sdk/types'; import type { JSONValue } from '@aws-lambda-powertools/commons'; -/* import { - addUserAgentMiddleware, - isSdkClient, -} from '@aws-lambda-powertools/commons'; */ /** * ## Intro diff --git a/packages/parameters/tests/unit/BaseProvider.test.ts b/packages/parameters/tests/unit/BaseProvider.test.ts index 845dea18c2..0bbb04e32a 100644 --- a/packages/parameters/tests/unit/BaseProvider.test.ts +++ b/packages/parameters/tests/unit/BaseProvider.test.ts @@ -22,7 +22,13 @@ describe('Class: BaseProvider', () => { class TestProvider extends BaseProvider { public constructor() { super({ - proto: class {}, + proto: class { + #name = 'TestProvider'; + + public hello(): string { + return this.#name; + } + }, }); }