Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: KafkaSelfManagedEventModel eventSource not correct #5559

Closed
Mavtti opened this issue Nov 14, 2024 · 3 comments · Fixed by #5584
Closed

Bug: KafkaSelfManagedEventModel eventSource not correct #5559

Mavtti opened this issue Nov 14, 2024 · 3 comments · Fixed by #5584
Assignees
Labels
bug Something isn't working parser Parser (Pydantic) utility

Comments

@Mavtti
Copy link

Mavtti commented Nov 14, 2024

Expected Behaviour

Hello,

the envelope KafkaSelfManagedEventModel should have eventSource = Literal["SelfManagedKafka"]

Current Behaviour

Currently, it expects eventSource = Literal["aws:SelfManagedKafka"]

Code snippet

class KafkaSelfManagedEventModel(KafkaBaseEventModel):
    """Self-managed Apache Kafka event trigger
    Documentation:
    --------------
    - https://docs.aws.amazon.com/lambda/latest/dg/with-kafka.html
    """

    eventSource: Literal["SelfManagedKafka"]

Possible Solution

No response

Steps to Reproduce

parse with envelope

Powertools for AWS Lambda (Python) version

latest

AWS Lambda function runtime

3.9

Packaging format used

PyPi

Debugging logs

@Mavtti Mavtti added bug Something isn't working triage Pending triage from maintainers labels Nov 14, 2024
@leandrodamascena
Copy link
Contributor

Hi @Mavtti! Thank you very much for catching this bug! We need to fix this.

Please let me know if you want to submit a PR to fix it, otherwise I can do it.

Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Nov 19, 2024
Copy link
Contributor

This is now released under 3.4.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Parser (Pydantic) utility
Projects
Status: Coming soon
Development

Successfully merging a pull request may close this issue.

3 participants