Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: remove unused rules from markdownlint #4208

Closed
1 of 2 tasks
dreamorosi opened this issue Apr 25, 2024 · 3 comments
Closed
1 of 2 tasks

Maintenance: remove unused rules from markdownlint #4208

dreamorosi opened this issue Apr 25, 2024 · 3 comments
Labels
internal Maintenance changes

Comments

@dreamorosi
Copy link
Contributor

Why is this needed?

While adding markdownlint to the TypeScript repo, @am29d pointed out that two of the settings used in the config are invalid.

Specifically, the headers one under MD013 and the allow_different_nesting one under MD024.

Neither of these two appear in the tool rules docs which indicates that they might have been removed or they were incorrect in the first place.

Which area does this relate to?

No response

Solution

Remove the two settings from the config file.

I am available to open a PR if welcome.

Acknowledgment

@leandrodamascena
Copy link
Contributor

Thanks for opening this @dreamorosi!

allow_different_nesting - Removed in this issue DavidAnson/markdownlint#1121
headers - Couldn't find any reference.

I'll remove both in the next week, thanks

@leandrodamascena
Copy link
Contributor

Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa heitorlessa moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes
Projects
Status: Shipped
Development

No branches or pull requests

3 participants