Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: import error and bad highlights on the Idempotency docs #4153

Closed
1 task done
rubenfonseca opened this issue Apr 18, 2024 · 2 comments · Fixed by #4154
Closed
1 task done

Docs: import error and bad highlights on the Idempotency docs #4153

rubenfonseca opened this issue Apr 18, 2024 · 2 comments · Fixed by #4154
Assignees
@rubenfonseca
Labels
documentation Improvements or additions to documentation

Comments

@rubenfonseca
Copy link
Contributor

What were you searching in the docs?

The Idempotency utility docs

Is this related to an existing documentation section?

https://docs.powertools.aws.dev/lambda/python/develop/utilities/idempotency/#bring-your-own-persistent-store

How can we improve?

The DataRecord import is wrong (should come from persistence.datarecord instead.

The highlights are also wrong:

image

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@rubenfonseca rubenfonseca added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Apr 18, 2024
@rubenfonseca rubenfonseca self-assigned this Apr 18, 2024
@rubenfonseca rubenfonseca moved this from Triage to Working on it in Powertools for AWS Lambda (Python) Apr 18, 2024
@rubenfonseca rubenfonseca removed the triage Pending triage from maintainers label Apr 18, 2024
@rubenfonseca rubenfonseca mentioned this issue Apr 18, 2024
Merged
7 tasks
@rubenfonseca rubenfonseca linked a pull request Apr 18, 2024 that will close this issue
docs(idempotency): fix highlight and import path #4154
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Apr 18, 2024
@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

This is now released under 2.38.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rubenfonseca rubenfonseca

Labels
documentation Improvements or additions to documentation
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(idempotency): fix highlight and import path aws-powertools/powertools-lambda-python
1 participant
@rubenfonseca