Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: All pages have a banner stating "You're not viewing the latest version" #2628

Closed
1 task done
allanlewis opened this issue Jul 3, 2023 · 6 comments
Closed
1 task done
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@allanlewis
Copy link

What were you searching in the docs?

Nothing in particular

Is this related to an existing documentation section?

All pages, e.g. the homepage: https://docs.powertools.aws.dev/lambda/python/latest/

How can we improve?

Remove the banner when I'm viewing the latest version of the docs.

Got a suggestion in mind?

The link "Click here to go to latest" points to this URL: https://docs.powertools.aws.dev/lambda/python/
Perhaps that's not the correct link?

I also note that the versions.json retrieved by my browser on load has an aliases key for each version. For most versions it's an empty array but for 2.19.0 it's "latest", i.e. a string not an array: should this be ["latest"], i.e. an array containing a single string?

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@allanlewis allanlewis added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Jul 3, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 3, 2023

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Jul 3, 2023
@heitorlessa heitorlessa moved this from Triage to Working on it in Powertools for AWS Lambda (Python) Jul 3, 2023
@heitorlessa
Copy link
Contributor

thank you so much @allanlewis for the heads up - we're merging the fix now cc @sthulb

@heitorlessa
Copy link
Contributor

@allanlewis could you double check from your end? It should be fixed now - we'll monitor for a newer release to avoid regression.

@allanlewis
Copy link
Author

Yep, that looks good now - I had to clear my cache before the banner was gone, but confirmed in a Chrome "incognito" window.

@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions
Copy link
Contributor

This is now released under 2.20.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Shipped
Development

No branches or pull requests

3 participants