Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update POWERTOOLS_DEV default value #1694

Closed
1 task done
dreamorosi opened this issue Nov 8, 2022 · 3 comments
Closed
1 task done

Docs: Update POWERTOOLS_DEV default value #1694

dreamorosi opened this issue Nov 8, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@dreamorosi
Copy link
Contributor

What were you searching in the docs?

Me and @ijemmy were checking the default value of the newly introduced POWERTOOLS_DEV environment variable in the docs.

In doing so we noticed that the current version of the docs says the value is 0 instead of false.

Is this related to an existing documentation section?

https://awslabs.github.io/aws-lambda-powertools-python/2.2.0/#environment-variables

How can we improve?

There's an opportunity to improve clarity on that env var by specifying that the default value is `false`.

Got a suggestion in mind?

The value should be false instead of 0.

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@dreamorosi dreamorosi added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Nov 8, 2022
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Nov 9, 2022
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Nov 9, 2022
@heitorlessa
Copy link
Contributor

Thanks a lot Andrea! Just rebuilt the latest docs with your PR ;)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions
Copy link
Contributor

This is now released under 2.3.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants