Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: remove legacy SQS Batch Processor #1462

Closed
1 of 2 tasks
rubenfonseca opened this issue Aug 19, 2022 · 2 comments
Closed
1 of 2 tasks

Maintenance: remove legacy SQS Batch Processor #1462

rubenfonseca opened this issue Aug 19, 2022 · 2 comments
Assignees
Labels
tech-debt Technical Debt tasks v2

Comments

@rubenfonseca
Copy link
Contributor

Summary

We kept the first implementation of the SQS Batch Processor for historical reasons. As of November 2021, it was no longer needed because native support was added to the services.

Why is this needed?

We've been recommending the native solution since we launched it. It's not worth to maintain two code paths to achieve the same functionality.

Which area does this relate to?

Batch processing

Solution

  • Immediately deprecate the feature with a warning (both for the sqs_batch_processor decorator and PartialSQSProcessor classes.
  • Completely remove the code on the next major version of Powertools

Acknowledgment

@rubenfonseca rubenfonseca added triage Pending triage from maintainers internal Maintenance changes area/batch and removed triage Pending triage from maintainers labels Aug 19, 2022
@rubenfonseca rubenfonseca self-assigned this Aug 19, 2022
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Sep 1, 2022
@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Sep 13, 2022
@aws-powertools aws-powertools deleted a comment from github-actions bot Sep 13, 2022
@rubenfonseca rubenfonseca reopened this Sep 13, 2022
@heitorlessa heitorlessa added the v2 label Sep 19, 2022
@rubenfonseca rubenfonseca self-assigned this Sep 26, 2022
@heitorlessa
Copy link
Contributor

Closing as we're wrap to launch V2

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical Debt tasks v2
Projects
None yet
Development

No branches or pull requests

2 participants