Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Documentation: Event Handler REST API CORS example #1018

Closed
joel-aws opened this issue Feb 10, 2022 · 3 comments
Closed

Fix Documentation: Event Handler REST API CORS example #1018

joel-aws opened this issue Feb 10, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@joel-aws
Copy link

In the example for CORS, line 3 should read:

from aws_lambda_powertools.event_handler.api_gateway import APIGatewayRestResolver, CORSConfig

Or CORSConfig should be added to __init__.py.

@joel-aws joel-aws added bug Something isn't working triage Pending triage from maintainers labels Feb 10, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 10, 2022

Thanks for opening your first issue here! We'll come back to you as soon as we can.

@joel-aws joel-aws changed the title Fix Documentation: Event Handler REST API example Fix Documentation: Event Handler REST API CORS example Feb 10, 2022
@michaelbrewer
Copy link
Contributor

@joel-aws - sorry my bad, i fixed the docs and also added CORSConfig to __init__.py for ease of use in the future releases.

@joel-aws
Copy link
Author

Thank you for your awesome work, @michaelbrewer; I just shared some of your latest changes on 1.25 with a colleague and we were stoked to use it!

@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants