Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include mermaid in mkdocs config. Fix identation and line numbers idempotency #400

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Aug 29, 2023

Please provide the issue number

Issue number: #396

Summary

include mermaid in mkdocs config. Fix identation and line numbers idempotency

Changes

Please provide a summary of what's being changed

include mermaid in mkdocs config. Fix identation and line numbers idempotency

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig August 29, 2023 12:43
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 29, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 29, 2023
@github-actions github-actions bot added the internal Maintenance changes label Aug 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (9ac1226) 72.88% compared to head (d1fdb7b) 72.80%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #400      +/-   ##
===========================================
- Coverage    72.88%   72.80%   -0.09%     
===========================================
  Files           82       82              
  Lines         3644     3644              
===========================================
- Hits          2656     2653       -3     
- Misses         988      991       +3     
Flag Coverage Δ
unittests 72.80% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit e241ca9 into develop Aug 29, 2023
7 checks passed
@hjgraca hjgraca deleted the hjgraca-fix-idempotency-docs branch August 29, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants