Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): minor updates, licensing #174

Merged
merged 1 commit into from
Jan 4, 2023
Merged

chore(ci): minor updates, licensing #174

merged 1 commit into from
Jan 4, 2023

Conversation

sliedig
Copy link
Contributor

@sliedig sliedig commented Dec 29, 2022

Issue number: #178

Summary

Minor changes/updates to tooling, templates and licensing.

Changes

Please provide a summary of what's being changed
Added linting, third-party license file, issue template for general enquiries

User experience

Please share what the user experience looks like before and after this change
N/A

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@github-actions
Copy link

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added internal Maintenance changes do-not-merge PRs that are blocked for varying reasons need-issue PR is missing a related issue for tracking change labels Dec 29, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 56.35% // Head: 56.29% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (d05bbf0) compared to base (810dd7f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
- Coverage    56.35%   56.29%   -0.06%     
===========================================
  Files           41       41              
  Lines         1778     1778              
===========================================
- Hits          1002     1001       -1     
- Misses         776      777       +1     
Flag Coverage Δ
unittests 56.29% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...da.Powertools.Logging/Internal/PowertoolsLogger.cs 90.36% <0.00%> (-0.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sliedig sliedig removed the need-issue PR is missing a related issue for tracking change label Dec 29, 2022
Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we need issue to merge

@amirkaws amirkaws removed the do-not-merge PRs that are blocked for varying reasons label Jan 4, 2023
Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sliedig sliedig merged commit f225e96 into aws-powertools:develop Jan 4, 2023
@sliedig sliedig deleted the sliedig-ci branch January 4, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants