Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in nemo.collections.nlp.parts.serialization.py #25

Closed
evellasques opened this issue Apr 5, 2024 · 1 comment
Closed

Typo in nemo.collections.nlp.parts.serialization.py #25

evellasques opened this issue Apr 5, 2024 · 1 comment

Comments

@evellasques
Copy link
Contributor

Hi,

In serialization.py, the save method will use SimpleSaver (when
save_xser is true):

class SimpleSaver:

    def __init__(self):
        pass

    def add_save_task(self, data, path):
        torch.save(data, path)

However, in line 105, it tries to instantiate SimplerSaver (instead of SimpleSaver):

  if saver is None:
      saver = SimplerSaver()

This is causing a crash:

    saver = SimplerSaver()
NameError: name 'SimplerSaver' is not defined
@evellasques
Copy link
Contributor Author

Addressed in PR #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant