Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation API Build Degrades Matrix Multiplication Performance #1005

Open
nandeeka opened this issue Oct 9, 2024 · 3 comments
Open

Allocation API Build Degrades Matrix Multiplication Performance #1005

nandeeka opened this issue Oct 9, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@nandeeka
Copy link

nandeeka commented Oct 9, 2024

I installed the latest version of Neuron using the .deb and .whl files @aws-serina-tan sent me. This version degrades the performance of my matrix multplication (currently being reviewed here).

Using Neuron 2.20 (the "Deep Learning AMI Neuron (Ubuntu 22.04) 20240927" AMI launched today), my latency distribution looks like:

Latency results are:
 NCLatency: 
p0 = 6929us
p1 = 6929us
p10 = 6929us
p25 = 6930us
p50 = 6931us
p90 = 6932us
p99 = 6932us
p100 = 6932us

With these newly installed files, my latency distribution now looks like:

Latency results are:
 NCLatency: 
p0 = 6947us
p1 = 6947us
p10 = 6947us
p25 = 6948us
p50 = 6949us
p90 = 6952us
p99 = 6952us
p100 = 6953us

I tried this with and without the --disable-dge flag. This flag had no effect.

@JonathanHenson
Copy link

Thanks for letting us know! I’m looking again at your pull request. I think I see some allocations that need to be hoisted outside the loops. I’ll provide comments there.

@JonathanHenson
Copy link

Nevermind, I was incorrect. We will reproduce these results internally and track it down. Thanks again!

@JonathanHenson
Copy link

After loooking into this we think it's more likely to be a change not related to nki or the allocation apis but rather a change for that path in the compiler or runtime.

@aws-taylor aws-taylor added the bug Something isn't working label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants