From a8f94fe89415686ecea76c60e51c5360783c0de2 Mon Sep 17 00:00:00 2001 From: Apoorva Kulkarni Date: Mon, 13 Feb 2023 14:50:26 -0800 Subject: [PATCH 1/4] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f563bbd05f..553c6ad47d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,6 +3,14 @@ 🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the [CONTRIBUTING](https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/CONTRIBUTING.md#contributing-via-pull-requests) guide for submitting pull-requests. +## :bangbang: Are you opening PR for a new add-on? :bangbang: + +At this time, the team is no longer accepting PRs for a new add-on in this repo. With the future direction of EKS Blueprints as stated in #1421, we are hitting the pause button on new add-on creation at this time. We are focussed on improving customer experience at the moment and will come back to add-ons in the near future once all changes outlined in issue https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/1421 are accomplished. + +Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. + +We welcome the EKS Blueprints community to continue the discussion in issue https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/1421 + ### Motivation @@ -13,15 +21,9 @@ Consult the [CONTRIBUTING](https://github.com/aws-ia/terraform-aws-eks-blueprint ### More - [ ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes) -- [ ] Yes, I have added a new example under [examples](https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples) to support my PR -- [ ] Yes, I have created another PR for add-ons under [add-ons](https://github.com/aws-samples/eks-blueprints-add-ons) repo (if applicable) - [ ] Yes, I have updated the [docs](https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/docs) for this feature - [ ] Yes, I ran `pre-commit run -a` with this PR -**Note**: Not all the PRs require a new example and/or doc page. In general: -- Use an existing example when possible to demonstrate a new addons usage -- A new docs page under `docs/add-ons/*` is required for new a new addon - ### For Moderators - [ ] E2E Test successfully complete before merge? From 65994673ae700ce5bd2bcd9f35f82d2a22bff3e1 Mon Sep 17 00:00:00 2001 From: Apoorva Kulkarni Date: Tue, 14 Feb 2023 14:14:37 -0800 Subject: [PATCH 2/4] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 553c6ad47d..3e8b92da71 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,13 +3,13 @@ 🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the [CONTRIBUTING](https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/CONTRIBUTING.md#contributing-via-pull-requests) guide for submitting pull-requests. -## :bangbang: Are you opening PR for a new add-on? :bangbang: +## :bangbang: PLEASE READ THIS FIRST :bangbang: -At this time, the team is no longer accepting PRs for a new add-on in this repo. With the future direction of EKS Blueprints as stated in #1421, we are hitting the pause button on new add-on creation at this time. We are focussed on improving customer experience at the moment and will come back to add-ons in the near future once all changes outlined in issue https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/1421 are accomplished. +The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We will be using the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation as shown in [examples](https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples). We will therefore not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers. -Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. +We are hitting also the pause button on new add-on creations at this time. Please do not submit new add-on PRs. Any such PR may be closed by the maintainers. -We welcome the EKS Blueprints community to continue the discussion in issue https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/1421 +Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. We welcome the EKS Blueprints community to continue the discussion in issue https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/1421 From 40b90190078bbb6a163fe37bf91b7bdef790a8e8 Mon Sep 17 00:00:00 2001 From: Apoorva Kulkarni Date: Tue, 14 Feb 2023 14:14:59 -0800 Subject: [PATCH 3/4] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3e8b92da71..51467e411e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,3 @@ -### What does this PR do? - -🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. -Consult the [CONTRIBUTING](https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/CONTRIBUTING.md#contributing-via-pull-requests) guide for submitting pull-requests. - ## :bangbang: PLEASE READ THIS FIRST :bangbang: The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We will be using the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation as shown in [examples](https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples). We will therefore not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers. @@ -11,6 +6,11 @@ We are hitting also the pause button on new add-on creations at this time. Pleas Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. We welcome the EKS Blueprints community to continue the discussion in issue https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/1421 +### What does this PR do? + +🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. +Consult the [CONTRIBUTING](https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/CONTRIBUTING.md#contributing-via-pull-requests) guide for submitting pull-requests. + ### Motivation From 7c04fd95778d14dabf6be0b4d27b645054bd6c43 Mon Sep 17 00:00:00 2001 From: Apoorva Kulkarni Date: Tue, 14 Feb 2023 14:17:15 -0800 Subject: [PATCH 4/4] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 51467e411e..cab935af62 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,8 @@ ## :bangbang: PLEASE READ THIS FIRST :bangbang: -The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We will be using the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation as shown in [examples](https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples). We will therefore not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers. +The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We have updated the [examples](https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples) to show how we use the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation. We will not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers. -We are hitting also the pause button on new add-on creations at this time. Please do not submit new add-on PRs. Any such PR may be closed by the maintainers. +We are hitting also the pause button on new add-on creations at this time until a future roadmap for add-ons is finalized. Please do not submit new add-on PRs. Any such PR may be closed by the maintainers. Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. We welcome the EKS Blueprints community to continue the discussion in issue https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/1421