External secrets will install helm chart regardless of argocd_manage_add_ons configuration

[atorrescogollo]

Description

When enabling external_secrets addon, it will deploy the helm chart regardless of what you configured through argocd_manage_add_ons. It should instead create only AWS IAM stuff and the namespace with the service account.

• ✋ I have searched the open/closed issues and my issue is not listed.

Versions

• Module version [Required]: v4.9.0

• Terraform version:

• Provider version(s):

Reproduction Code [Required]

module "addons" {
  source = "github.com/aws-ia/terraform-aws-eks-blueprints//modules/kubernetes-addons?ref=v4.9.0"

  eks_cluster_id = module.this.eks_cluster_id

  # K8s Add-ons
  enable_argocd         = true
  argocd_manage_add_ons = true
  enable_external_secrets = true
}

Steps to reproduce the behavior:

Just doing a plan you'll see it's going to create this helm_release: module.addons.module.external_secrets[0].module.helm_addon.helm_release.addon[0]

Expected behaviour

It doesn't install the helm chart for external_secrets since argocd_manage_add_ons is enabled, but it does create the namespace, service account and IAM IRSA related stuff.

Actual behaviour

It installs the helm chart although argocd_manage_add_ons is enabled

Terminal Output Screenshot(s)

Additional context