-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Make it possible to disable namespace creation for ArgoCD #704
Comments
I 'd love to take a stab at this and try and get it done this week if folks think that it makes sense. |
#595 is similar but I did not touch argocd yet |
@bryantbiggs What are the odds that #595 could include ArgoCD as well, and might get merged in this week? I am nearing the end of my current project and am just hoping to get this one last fix in before I move on to other things. I am wondering if it would make sense to keep this separate and simply focus on making the ArgoCD namespace optional in this issue. cc/ @vara-bonthu |
yes I left out ArgoCD since its more complex and involved. We still haven't taken a direction on how we are going to handle #595 - I was just referencing since these are all in the same thought process around giving more control around namespaces to users |
@spkane does this support the use case you are looking for? https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/595/files#diff-2c4637e9f759d1032d9ce7d443cb6d6247da40884ffca5b98fc2ec7a08923e6fR12 |
@bryantbiggs I think that would get the job done. I just need to be able to tell the module not to create the I noticed that you were checking to make sure that the namespace wasn't defined as |
Thank you @bryantbiggs. This got me what I needed. |
Is your feature request related to a problem? Please describe
For ArgoCD, I want to make sure the very first refresh, right after the argocd_applications are installed works, but to do this I need to have a few k8s secrets (with this label: "argocd.argoproj.io/secret-type" : "repository") in place so that Argo can read our private Github repos, and to do this, I really need to create the namespace BEFORE the
kubernetes-addons
module is run, to ensure that the secrets exist in the namespace the very first-time ArgoCD tries to connect to the repos.Describe the solution you'd like
It would be great to have something like
argocd_create_namespace = true
as a default that can be overridden. The default behavior is the same as today.argocd_create_namespace = false
would skip the namespace creation here:https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/kubernetes-addons/argocd/main.tf#L11-L15
and assume that the namespace already exists.
The text was updated successfully, but these errors were encountered: