Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Need to add windows as supported github actions #164

Open
diane-hj opened this issue Sep 4, 2024 · 0 comments
Open

Maintenance: Need to add windows as supported github actions #164

diane-hj opened this issue Sep 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@diane-hj
Copy link
Contributor

diane-hj commented Sep 4, 2024

Description

Currently only linux and mac are part of supported github actions: https://github.com/aws-deadline/deadline-cloud-for-nuke/blob/mainline/.github/workflows/code_quality.yml#L17

We would like to add windows as well.

Currently, the following test case(test_config_has_absolute_search_path) does not work windows: https://github.com/diane-hj/deadline-cloud-for-nuke/blob/be4f3fc77bc0d0e8aa9c94e9239eaa29dbf17b95/test/unit/nuke_util/test_ocio.py#L112

The root cause could be because PurePath will evaluate to the current OS flavour, but these absolute posix paths don't look absolute on windows.

>>> PurePath("/asdf/asdf")
PurePosixPath('/asdf/asdf')
>>> PurePath("/asdf/asdf").is_absolute()
True
>>> PureWindowsPath("/asdf/asdf").is_absolute()
False

Solution

We need to fix the test case and enable windows into supported github actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants