Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.27.1, code-generator v0.27.1 #42

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Sep 14, 2023

Update to ACK runtime v0.27.1, code-generator v0.27.1



NOTE:
This PR increments the release version of service controller from v1.0.3 to v1.0.4

Once this PR is merged, release v1.0.4 will be automatically created for emrcontainers-controller

Please close this PR, if you do not want the new patch release for emrcontainers-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building emrcontainers-controller ====
Copying common custom resource definitions into emrcontainers
Building Kubernetes API objects for emrcontainers
Generating deepcopy code for emrcontainers
Generating custom resource definitions for emrcontainers
Building service controller for emrcontainers
Generating RBAC manifests for emrcontainers
Running gofmt against generated code for emrcontainers
Updating additional GitHub repository maintenance files
==== building emrcontainers-controller release artifacts ====
Building release artifacts for emrcontainers-v1.0.4
Generating common custom resource definitions
Generating custom resource definitions for emrcontainers
Generating RBAC manifests for emrcontainers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@ack-prow
Copy link

ack-prow bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Sep 15, 2023
@ack-prow ack-prow bot merged commit b75141c into main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants