Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump up github.com/aws-controllers-k8s/pkg to v0.0.6 #469

Merged
merged 2 commits into from
Sep 14, 2023
Merged

bump up github.com/aws-controllers-k8s/pkg to v0.0.6 #469

merged 2 commits into from
Sep 14, 2023

Conversation

Julian-Chu
Copy link
Contributor

@Julian-Chu Julian-Chu commented Sep 14, 2023 •
edited by a-hilaly
Loading

bump up github.com/aws-controllers-k8s/pkg to v0.0.6

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 14, 2023
@ack-prow
Copy link

ack-prow bot commented Sep 14, 2023

Hi @Julian-Chu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly a-hilaly changed the title bump up pkg to v0.0.6 bump up github.com/aws-controllers-k8s/pkg to v0.0.6 Sep 14, 2023
a-hilaly
a-hilaly approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Julian-Chu !

/ok-to-test
/lgtm

@ack-prow ack-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 14, 2023
@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2023
@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@Julian-Chu
Copy link
Contributor Author

/retest

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@ack-prow
Copy link

ack-prow bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, Julian-Chu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit daee073 into aws-controllers-k8s:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jaypipes jaypipes Awaiting requested review from jaypipes

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Julian-Chu @a-hilaly