Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add persist option for MySQL and RabbitMQ #206

Merged
merged 2 commits into from
Apr 13, 2023
Merged

feat: Add persist option for MySQL and RabbitMQ #206

merged 2 commits into from
Apr 13, 2023

Conversation

yubingjiaocn
Copy link
Contributor

Addressing - #205

Copy link
Collaborator

@niallthomson niallthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @yubingjiaocn ! Only a minor comment across the storage class default value.

accessModes:
- ReadWriteOnce
size: 10Gi
storageClass: gp2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the convention is to set this to an empty string so that it uses the default storage class of the cluster.

accessModes:
- ReadWriteOnce
size: 10Gi
storageClass: gp2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the convention is to set this to an empty string so that it uses the default storage class of the cluster.

accessModes:
- ReadWriteOnce
size: 10Gi
storageClass: gp2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the convention is to set this to an empty string so that it uses the default storage class of the cluster.

@yubingjiaocn
Copy link
Contributor Author

I commented the storageClass in values.yaml so it will use default storage class. If storageClass is set to empty string, no storage class or dynamic provisioning will be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants