Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect JSON Schema draft URI #83

Closed
iann0036 opened this issue Mar 5, 2020 · 2 comments
Closed

Incorrect JSON Schema draft URI #83

iann0036 opened this issue Mar 5, 2020 · 2 comments
Assignees

Comments

@iann0036
Copy link

iann0036 commented Mar 5, 2020

According to the spec, the draft-07 schema URI should begin with http:// and not https:// (schema ID does not necessarily mean the network location where the resource is stored).

So I believe the references should be changed to reflect this.

@PatMyron
Copy link
Contributor

PatMyron commented Mar 9, 2020

looks like they were flipped here: #57

@johnttompkins
Copy link
Contributor

If if remember correctly, there was some justification for the http->https changes in the references, as the library we used did not handle http 301 redirects returned by json-schema.org.

This issue json-schema-org/json-schema-org.github.io#236 seems related and was resolved around the same time as #57 . Anyways, I changed them back and it looks to be working correctly with all tests passing. Will send out a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants