fix(awsmobileclient): Makes fetch aws credentials serial with the rest of the calls #4202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
samkudr
pushed a commit
to samkudr/aws-sdk-ios
that referenced
this pull request
Sep 26, 2022
gabek
pushed a commit
to KeepSafe/aws-sdk-ios
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws-amplify/amplify-swift#1822
Description of changes: Fetching AWSCredentials call just after signIn is causing multiple thread to cause issue in the underlying CognitoSDK. This PR is to mitigate the issue by queueing the getCredentials call along with other calls. So all api invocation to the underlying CognitoSDK for fetching credentials will be queued.
Check points:
Documentation update for the change if requiredBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.