AWSMobileClient:Auth add parameters for SignInResult init in getNewPasswordDetails #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing parameters for getNewPasswordDetails to have requiredAttributes available
harsh62
reviewed
Jul 14, 2022
...ces/AWSMobileClient/Helpers/UserPoolHelper/AWSMobileClient+UserPoolAuthHelperCallbacks.swift
Outdated
Show resolved
Hide resolved
…obileClient+UserPoolAuthHelperCallbacks.swift Co-authored-by: Harshdeep Singh <[email protected]>
harsh62
approved these changes
Aug 15, 2022
harsh62
approved these changes
Aug 15, 2022
samkudr
pushed a commit
to samkudr/aws-sdk-ios
that referenced
this pull request
Sep 26, 2022
…etNewPasswordDetails (aws-amplify#4200) * Update AWSMobileClient+UserPoolAuthHelperCallbacks.swift Add missing parameters for getNewPasswordDetails to have requiredAttributes available * Update AWSAuthSDK/Sources/AWSMobileClient/Helpers/UserPoolHelper/AWSMobileClient+UserPoolAuthHelperCallbacks.swift Co-authored-by: Harshdeep Singh <[email protected]> Co-authored-by: Harshdeep Singh <[email protected]>
gabek
pushed a commit
to KeepSafe/aws-sdk-ios
that referenced
this pull request
Aug 31, 2023
…etNewPasswordDetails (aws-amplify#4200) * Update AWSMobileClient+UserPoolAuthHelperCallbacks.swift Add missing parameters for getNewPasswordDetails to have requiredAttributes available * Update AWSAuthSDK/Sources/AWSMobileClient/Helpers/UserPoolHelper/AWSMobileClient+UserPoolAuthHelperCallbacks.swift Co-authored-by: Harshdeep Singh <[email protected]> Co-authored-by: Harshdeep Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't have access to AdditionalInfos when we receive nextStep = .newPasswordRequired. The parameter is never passed to SignInResult init in getNewPasswordDetails function. We receive every time parameters = nil because he is implemented like an optional parameter and never set in SignIntResult init into getNewPasswordDetails.
Issue #, if available: #4201
Description of changes:
Add missing parameters in getNewPasswordDetails to have requiredAttributes available in SignIntResult init
Check points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.