Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending Release: Use Improved Pluralization #3135

Closed
lawmicha opened this issue Aug 10, 2023 · 11 comments
Closed

Pending Release: Use Improved Pluralization #3135

lawmicha opened this issue Aug 10, 2023 · 11 comments
Assignees
Labels
api Issues related to the API category bug Something isn't working datastore Issues related to the DataStore category

Comments

@lawmicha
Copy link
Member

lawmicha commented Aug 10, 2023

Describe the bug

This issue is to track the release of Improved Pluralization in aws-amplify/amplify-codegen#255

We have a few issues that are open that will be referenced in this issue, while closing them in favor of tracking this issue.

Steps To Reproduce

N/A

Expected behavior

N/A

Amplify Framework Version

N/A

Amplify Categories

API

Dependency manager

Swift PM

Swift version

N/A

CLI version

N/A

Xcode version

N/A

Relevant log output

<details>
<summary>Log Messages</summary>


INSERT LOG MESSAGES HERE
```

Is this a regression?

Yes

Regression additional context

No response

Platforms

No response

OS Version

N/A

Device

N/A

Specific to simulators

No response

Additional context

No response

@github-actions
Copy link
Contributor

This issue was opened by a maintainer of this repository; updates will be posted here. If you are also experiencing this issue, please comment here with any relevant information so that we're aware and can prioritize accordingly.

@lawmicha
Copy link
Member Author

#1707 (comment)

@lawmicha
Copy link
Member Author

#1443

@lawmicha lawmicha added api Issues related to the API category bug Something isn't working p2 pending-release Code has been merged but pending release Code has been merged but pending release labels Aug 10, 2023
@lawmicha
Copy link
Member Author

#1505

@lawmicha
Copy link
Member Author

#1841

@lawmicha
Copy link
Member Author

#2460

@shawnyapa
Copy link

Appreciate the attention to fix this. I have personally run into this issue and had to work around it.
Is there an approximate ETA for the CLI tool release that will include this fix?

@lawmicha
Copy link
Member Author

Hey @shawnyapa, please track the codegen changes for swift in aws-amplify/amplify-codegen#667 (it was merged in today!)

@lawmicha lawmicha self-assigned this Aug 15, 2023
@lawmicha
Copy link
Member Author

lawmicha commented Sep 8, 2023

Using Amplify CLI version 12.4.0
Tested with the following schema, gathered from the various issues open.

# This "input" configures a global authorization rule to enable public access to
# all models in this schema. Learn more about authorization rules here: https://docs.amplify.aws/cli/graphql/authorization-rules
input AMPLIFY { globalAuthRule: AuthRule = { allow: public } } # FOR TESTING ONLY!

type NoteData @model {
    id: ID!
    name: String!
    description: String
    image: String
}

type Activity @model {
    id: ID!
    name: String
}

type EventNews @model {
    id: ID!
    name: String
}

type Protocols @model {
    id: ID!
    name: String
}

amplify codegen models

 model.listPluralName = "Activities"
    model.syncPluralName = "Activities"

    
    model.listPluralName = "EventNews"
    model.syncPluralName = "EventNews"


    model.listPluralName = "NoteData"
    model.syncPluralName = "NoteData"


  model.listPluralName = "Protocols"
    model.syncPluralName = "Protocols"

Looking over the AppSync operations
image

The library will make use of the properties listPluralName to create the list<Model> operation string. Activites, EventNews, NoteData, Protocols matches

@lawmicha lawmicha closed this as completed Sep 8, 2023
@github-actions github-actions bot removed the pending-release Code has been merged but pending release Code has been merged but pending release label Sep 8, 2023
@lawmicha
Copy link
Member Author

lawmicha commented Sep 8, 2023

For customers impacted by this, please use Amplify CLI 12.4.0 or greater to get the fix for the pluralization issue, and re-run codegen amplify codegen models

@sebsto
Copy link

sebsto commented Sep 8, 2023

I confirm this is working for me. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to the API category bug Something isn't working datastore Issues related to the DataStore category
Projects
None yet
Development

No branches or pull requests

3 participants