Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR previews for forks #508

Open
ericclemmons opened this issue Mar 12, 2020 · 5 comments
Open

PR previews for forks #508

ericclemmons opened this issue Mar 12, 2020 · 5 comments
Labels
feature-request New feature or request

Comments

@ericclemmons
Copy link

Is your feature request related to a problem? Please describe.

PR previews only work for branches on origin, not for forks.

Describe the solution you'd like

Every PR for a front-end site should generate a PR preview.

Additional context

Example of a PR with a preview (notice the branch name & the preview link under "Checks"):

Example of a PR without a preview (notice the forked branch name & how "Checks" doesn't have a preview):

@cslogan-red cslogan-red added the feature-request New feature or request label Mar 12, 2020
@jbeveland27
Copy link

Just adding that I'd really like to see this feature. Our team functions primarily through a fork+PR flow and it's how we encourage others to interact with our project(s) as well. Having PR previews work for forks is highly desirable.

@zstix
Copy link

zstix commented Jun 2, 2020

+1 for this feature. Our team accepts contributions via the fork & PR workflow.

@brentley
Copy link

Another +1... I came here after spending quite a while setting up previews only to realize our forking model doesn't work. that could be called out in the documentation until the feature is added. thanks!

@jpvajda
Copy link

jpvajda commented Sep 16, 2020

+1 one for this feature as well!

@swaminator
Copy link
Contributor

@jpvajda @ericclemmons @brentley @jbeveland27 @zstix we have implemented this and the feature is rolling out to all regions over the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants