Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to pass preferPrivateSession flag? #880

Closed
SuTran opened this issue Sep 14, 2021 · 7 comments
Closed

how to pass preferPrivateSession flag? #880

SuTran opened this issue Sep 14, 2021 · 7 comments
Assignees
Labels
auth Issues related to the Auth Category feature-request A request for a new feature or an enhancement to an existing API or category. pending-release Issues that have been addressed in main but have not been released question A question about the Amplify Flutter libraries

Comments

@SuTran
Copy link
Contributor

SuTran commented Sep 14, 2021

Hi team,

I found an update that helps user not to see a web view displayed when they sign out.
https://github.com/aws-amplify/amplify-ios/releases/tag/v1.6.0

Amplify.Auth.signInWithWebUI(presentationAnchor: self.view.window!, 
                             options: .preferPrivateSession()) { ... }

It can help to resolve issue like aws-amplify/amplify-swift#1016

Have we apply this new config into amplify-flutter? Thanks

@offlineprogrammer offlineprogrammer added the question A question about the Amplify Flutter libraries label Sep 14, 2021
@fjnoyp
Copy link
Contributor

fjnoyp commented Sep 14, 2021

Hi @SuTran thanks for reaching out we are looking into this issue.

@offlineprogrammer offlineprogrammer added requires-android-fix This issue is the result of an underlying Amplify Android issue that needs to be fixed. feature-request A request for a new feature or an enhancement to an existing API or category. and removed requires-android-fix This issue is the result of an underlying Amplify Android issue that needs to be fixed. labels Sep 14, 2021
@Ashish-Nanda Ashish-Nanda added the auth Issues related to the Auth Category label Sep 14, 2021
@fjnoyp fjnoyp self-assigned this Sep 14, 2021
@SuTran
Copy link
Contributor Author

SuTran commented Sep 16, 2021

@fjnoyp thanks for your response. May I work on this too?

@fjnoyp
Copy link
Contributor

fjnoyp commented Sep 16, 2021

Sure @SuTran we'd be happy to have you contribute! I'll respond tomorrow with what the API experience should look like and then you can submit a PR :)

@SuTran
Copy link
Contributor Author

SuTran commented Sep 17, 2021

Thanks @fjnoyp . I prepare this PR #897 . Can you help to review if you have a chance.

@fjnoyp
Copy link
Contributor

fjnoyp commented Sep 17, 2021

Thanks @SuTran we'll continue the conversation on your PR.

@Ashish-Nanda Ashish-Nanda added the pending-release Issues that have been addressed in main but have not been released label Sep 24, 2021
@dander11
Copy link

dander11 commented Oct 6, 2021

@fjnoyp is there any timeline for when this PR #897 will be released? It is currently blocking us from being able to release our app to production.

@fjnoyp
Copy link
Contributor

fjnoyp commented Oct 13, 2021

Hi @SuTran @dander11 this PR should be included in the latest Amplify Flutter release 0.2.5 we made earlier this week. If you used amplify_auth_cognito: ^0.2.0 in your pubspec.yaml you should automatically be updated to this version.

Closing this issue for now.

@fjnoyp fjnoyp closed this as completed Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Issues related to the Auth Category feature-request A request for a new feature or an enhancement to an existing API or category. pending-release Issues that have been addressed in main but have not been released question A question about the Amplify Flutter libraries
Projects
None yet
Development

No branches or pull requests

5 participants